8000 TST: disable longdouble string/print tests on Linux aarch64 · rgommers/numpy@97ba2ea · GitHub
[go: up one dir, main page]
Skip to content

Commit 97ba2ea

Browse files
rgommersrgommers
committed
TST: disable longdouble string/print tests on Linux aarch64
See numpygh-23974
1 parent a5ef06b commit 97ba2ea

File tree

4 files changed

+29
-8
lines changed

4 files changed

+29
-8
lines changed

‎numpy/core/tests/test_arrayprint.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import platform
12
import sys
23
import gc
34
from hypothesis import given
@@ -161,6 +162,8 @@ def test_fieldless_structured(self):
161162

162163

163164
class TestComplexArray:
165+
@pytest.mark.xfail(platform.machine() == 'aarch64',
166+
reason="Failing on Meson build, see gh-23974")
164167
def test_str(self):
165168
rvals = [0, 1, -1, np.inf, -np.inf, np.nan]
166169
cvals = [complex(rp, ip) for rp in rvals for ip in rvals]

‎numpy/core/tests/test_print.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import sys
2+
import platform
23

34
import pytest
45

@@ -12,7 +13,14 @@
1213
_REF = {np.inf: 'inf', -np.inf: '-inf', np.nan: 'nan'}
1314

1415

15-
@pytest.mark.parametrize('tp', [np.float32, np.double, np.longdouble])
16+
# longdouble printing issue on aarch64, see gh-23974
17+
if platform.machine() == 'aarch64':
18+
_real_dtypes = [np.float32, np.double]
19+
_complex_dtypes = [np.complex64, np.cdouble]
20+
else:
21+
_real_dtypes = [np.float32, np.double, np.longdouble]
22+
_complex_dtypes = [np.complex64, np.cdouble, np.clongdouble]
23+
@pytest.mark.parametrize('tp', _real_dtypes)
1624
def test_float_types(tp):
1725
""" Check formatting.
1826
@@ -34,7 +42,7 @@ def test_float_types(tp):
3442
err_msg='Failed str formatting for type %s' % tp)
3543

3644

37-
@pytest.mark.parametrize('tp', [np.float32, np.double, np.longdouble])
45+
@pytest.mark.parametrize('tp', _real_dtypes)
3846
def test_nan_inf_float(tp):
3947
""" Check formatting of nan & inf.
4048
@@ -48,7 +56,7 @@ def test_nan_inf_float(tp):
4856
err_msg='Failed str formatting for type %s' % tp)
4957

5058

51-
@pytest.mark.parametrize('tp', [np.complex64, np.cdouble, np.clongdouble])
59+
@pytest.mark.parametrize('tp', _complex_dtypes)
5260
def test_complex_types(tp):
5361
"""Check formatting of complex types.
5462
@@ -74,7 +82,7 @@ def test_complex_types(tp):
7482
err_msg='Failed str formatting for type %s' % tp)
7583

7684

77-
@pytest.mark.parametrize('dtype', [np.complex64, np.cdouble, np.clongdouble])
85+
@pytest.mark.parametrize('dtype', _complex_dtypes)
7886
def test_complex_inf_nan(dtype):
7987
"""Check inf/nan formatting of complex types."""
8088
TESTS = {
@@ -119,7 +127,7 @@ def _test_redirected_print(x, tp, ref=None):
119127
err_msg='print failed for type%s' % tp)
120128

121129

122-
@pytest.mark.parametrize('tp', [np.float32, np.double, np.longdouble])
130+
@pytest.mark.parametrize('tp', _real_dtypes)
123131
def test_float_type_print(tp):
124132
"""Check formatting when using print """
125133
for x in [0, 1, -1, 1e20]:
@@ -135,7 +143,7 @@ def test_float_type_print(tp):
135143
_test_redirected_print(float(1e16), tp, ref)
136144

137145

138-
@pytest.mark.parametrize('tp', [np.complex64, np.cdouble, np.clongdouble])
146+
@pytest.mark.parametrize('tp', _complex_dtypes)
139147
def test_complex_type_print(tp):
140148
"""Check formatting when using print """
141149
# We do not create complex with inf/nan directly because the feature is

‎numpy/core/tests/test_scalarprint.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@
1313
class TestRealScalars:
1414
def test_str(self):
1515
svals = [0.0, -0.0, 1, -1, np.inf, -np.inf, np.nan]
16-
styps = [np.float16, np.float32, np.float64, np.longdouble]
16+
# longdouble printing issue on aarch64, see gh-23974
17+
if platform.machine() == 'aarch64':
18+
styps = [np.float16, np.float32, np.float64]
19+
else:
20+
styps = [np.float16, np.float32, np.float64, np.longdouble]
1721
wanted = [
1822
['0.0', '0.0', '0.0', '0.0' ],
1923
['-0.0', '-0.0', '-0.0', '-0.0'],
@@ -263,7 +267,9 @@ def test_dragon4(self):
263267
def test_dragon4_interface(self):
264268
tps = [np.float16, np.float32, np.float64]
265269
# test is flaky for musllinux on np.float128
266-
if hasattr(np, 'float128') and not IS_MUSL:
270+
# also currently failing on Linux aarch64 with Meson (see gh-23974)
271+
is_aarch64 = platform.machine() == 'aarch64'
272+
if hasattr(np, 'float128') and not IS_MUSL and not is_aarch64:
267273
tps.append(np.float128)
268274

269275
fpos = np.format_float_positional

‎numpy/core/tests/test_strings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import pytest
22

3+
import platform
34
import operator
45
import numpy as np
56

@@ -88,6 +89,9 @@ def test_string_comparisons_empty(op, ufunc, sym, dtypes):
8889
@pytest.mark.parametrize("str_dt", ["S", "U"])
8990
@pytest.mark.parametrize("float_dt", np.typecodes["AllFloat"])
9091
def test_float_to_string_cast(str_dt, float_dt):
92+
if platform.machine() == 'aarch64' and float_dt == 'g':
93+
pytest.xfail("string repr issues with longdouble, see gh-23974")
94+
9195
float_dt = np.dtype(float_dt)
9296
fi = np.finfo(float_dt)
9397
arr = np.array([np.nan, np.inf, -np.inf, fi.max, fi.min], dtype=float_dt)

0 commit comments

Comments
 (0)
0