8000 merged branch henrikbjorn/framework-bundle-composer (PR #3100) · rfanjul/symfony@a81ab35 · GitHub
[go: up one dir, main page]

Skip to content

Commit a81ab35

Browse files
committed
merged branch henrikbjorn/framework-bundle-composer (PR symfony#3100)
Commits ------- 78ce60c Add config as required 10b3cde [FrameworkBundle] Add missing dependency and recommended libraries fixes symfony#3094 Discussion ---------- [FrameworkBundle] Add missing dependency and recommended libraries Fixes symfony#3094 --------------------------------------------------------------------------- by fabpot at 2012-01-12T17:31:14Z You forgot the dependency on config? Is it on purpose --------------------------------------------------------------------------- by henrikbjorn at 2012-01-12T17:39:20Z the config is recommended package on the DependencyInjection component. --------------------------------------------------------------------------- by stof at 2012-01-12T17:40:56Z @henrikbjorn yeah, but it is *required* dependency for FrameworkBundle, not only recommended --------------------------------------------------------------------------- by henrikbjorn at 2012-01-12T17:41:56Z well it will install it by default as it is recommended. --------------------------------------------------------------------------- by stof at 2012-01-12T17:43:05Z @henrikbjorn yeah, but it will be skipped if the user asks to avoid recommended packages (the flag is not implemented yet IIRC) which would break FrameworkBundle as it requires the component
2 parents 6b4e4d9 + 78ce60c commit a81ab35

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/Symfony/Bundle/FrameworkBundle/composer.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
< 8F27 div class="diff-text-inner color-fg-muted">@@ -18,6 +18,8 @@
1818
],
1919
"require": {
2020
"php": ">=5.3.2",
21+
"symfony/dependency-injection" : "self.version",
22+
"symfony/config" : "self.version",
2123
"symfony/event-dispatcher": "self.version",
2224
"symfony/http-kernel": "self.version",
2325
"symfony/filesystem": "self.version",
@@ -28,6 +30,7 @@
2830
},
2931
"recommend": {
3032
"symfony/console": "self.version",
33+
"symfony/finder": "self.version",
3134
"symfony/form": "self.version",
3235
"symfony/validator": "self.version"
3336
},

0 commit comments

Comments
 (0)
0