Merge pull request libgit2#1205 from libgit2/packbuilder-fixup

nulltoken · nulltoken · commit 78cad1dd3a25 · 2015-10-22T19:54:00.000+02:00
PackBuilder Fixup
diff --git a/LibGit2Sharp/PackBuilder.cs b/LibGit2Sharp/PackBuilder.cs
@@ -11,7 +11,6 @@ namespace LibGit2Sharp
     public sealed class PackBuilder : IDisposable
     {
         private readonly PackBuilderSafeHandle packBuilderHandle;
-        private readonly Repository repo;
 
         /// <summary>
         /// Constructs a PackBuilder for a <see cref="Repository"/>.
@@ -20,8 +19,7 @@ internal PackBuilder(Repository repository)
         {
             Ensure.ArgumentNotNull(repository, "repository");
 
-            repo = repository;
-            packBuilderHandle = Proxy.git_packbuilder_new(repo.Handle);
+            packBuilderHandle = Proxy.git_packbuilder_new(repository.Handle);
         }
 
         /// <summary>
@@ -79,7 +77,7 @@ public void AddRecursively(ObjectId id)
         /// <summary>
         /// Disposes the PackBuilder object.
         /// </summary>
-        public void Dispose()
+        void IDisposable.Dispose()
         {
             packBuilderHandle.SafeDispose();
         }
@@ -143,6 +141,9 @@ public struct PackBuilderResults
     /// </summary>
     public sealed class PackBuilderOptions
     {
+        private string path;
+        private int nThreads;
+
         /// <summary>
         /// Constructor
         /// </summary>
@@ -188,7 +189,7 @@ public int MaximumNumberOfThreads
             {
                 if (value < 0)
                 {
-                    throw new ArgumentException("Argument can not be negative", "MaximumNumberOfThreads");
+                    throw new ArgumentException("Argument can not be negative", "value");
                 }
 
                 nThreads = value;
@@ -197,10 +198,6 @@ public int MaximumNumberOfThreads
             {
                 return nThreads;
             }
-
         }
-
-        private string path;
-        private int nThreads;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ namespace LibGit2Sharp`
`11`	`11`	`public sealed class PackBuilder : IDisposable`
`12`	`12`	`{`
`13`	`13`	`private readonly PackBuilderSafeHandle packBuilderHandle;`
`14`		`- private readonly Repository repo;`
`15`	`14`
`16`	`15`	`/// <summary>`
`17`	`16`	`/// Constructs a PackBuilder for a <see cref="Repository"/>.`
`@@ -20,8 +19,7 @@ internal PackBuilder(Repository repository)`
`20`	`19`	`{`
`21`	`20`	`Ensure.ArgumentNotNull(repository, "repository");`
`22`	`21`
`23`		`- repo = repository;`
`24`		`- packBuilderHandle = Proxy.git_packbuilder_new(repo.Handle);`
	`22`	`+ packBuilderHandle = Proxy.git_packbuilder_new(repository.Handle);`
`25`	`23`	`}`
`26`	`24`
`27`	`25`	`/// <summary>`
`@@ -79,7 +77,7 @@ public void AddRecursively(ObjectId id)`
`79`	`77`	`/// <summary>`
`80`	`78`	`/// Disposes the PackBuilder object.`
`81`	`79`	`/// </summary>`
`82`		`- public void Dispose()`
	`80`	`+ void IDisposable.Dispose()`
`83`	`81`	`{`
`84`	`82`	`packBuilderHandle.SafeDispose();`
`85`	`83`	`}`
`@@ -143,6 +141,9 @@ public struct PackBuilderResults`
`143`	`141`	`/// </summary>`
`144`	`142`	`public sealed class PackBuilderOptions`
`145`	`143`	`{`
	`144`	`+ private string path;`
	`145`	`+ private int nThreads;`
	`146`	`+`
`146`	`147`	`/// <summary>`
`147`	`148`	`/// Constructor`
`148`	`149`	`/// </summary>`
`@@ -188,7 +189,7 @@ public int MaximumNumberOfThreads`
`188`	`189`	`{`
`189`	`190`	`if (value < 0)`
`190`	`191`	`{`
`191`		`- throw new ArgumentException("Argument can not be negative", "MaximumNumberOfThreads");`
	`192`	`+ throw new ArgumentException("Argument can not be negative", "value");`
`192`	`193`	`}`
`193`	`194`
`194`	`195`	`nThreads = value;`
`@@ -197,10 +198,6 @@ public int MaximumNumberOfThreads`
`197`	`198`	`{`
`198`	`199`	`return nThreads;`
`199`	`200`	`}`
`200`		`-`
`201`	`201`	`}`
`202`		`-`
`203`		`- private string path;`
`204`		`- private int nThreads;`
`205`	`202`	`}`
`206`	`203`	`}`