Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 4 files changed
- 2 contributors
Commits on Nov 1, 2021
-
-
Merge pull request #902 from remix-run/jacob/rem-473-redirects-after-…
…action-are-persisting fix: search params persisting on redirects
-
-
fix: remove generic
StatefromLocationtype`location.state` is like `location.search`, there's no way for a type system to do its job with a value that isn't controlled by the code. Similarly, the DOM type for `URLSearchParams` is not generic. And the built-in types for `window.history.state` is `any` without a generic. The only way to type check `location.state` or `location.search` or really any value on `location.*` is to do it at runtime and then get type hints from using type guards. ```ts interface ModalLocation extends Location { state: "modal" } function isModalLocation(location) location is ModalLocation { return location.state === "modal" } if (isModalLocation(location)) { // runtime by necessity but now also type safe in here } ``` -
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.0.1...v5.0.2