[CodeQuality] Skip late static binding use on CompleteDynamicPropertiesRector (#6938)

samsonasik · actions-user · web-flow · commit 802813072b08 · 2025-05-28T05:58:27.000Z
* [CodeQuality] Skip late static binding use on CompleteDynamicPropertiesRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action &lt;actions@github.com&gt;
diff --git a/rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_late_static_binding.php.inc b/rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_late_static_binding.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;
+
+abstract class SkipLateStaticBinding
+{
+    public const PRIMARY_KEY = 'id';
+
+    public function insert(): void
+    {
+        $this->{static::PRIMARY_KEY} = 1;
+    }
+}
diff --git a/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php b/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php
@@ -11,7 +11,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticCall;
-use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\NodeVisitor;
@@ -135,7 +135,7 @@ private function shouldSkipPropertyFetch(PropertyFetch $propertyFetch): bool
             return true;
         }
 
-        return $propertyFetch->name instanceof Variable;
+        return ! $propertyFetch->name instanceof Identifier;
     }
 
     /**
