➤ PM Bot commented:

Jira ticket: RCORE-2231

Why should a client reset with no local changes produce an upload progress notification? Nothing about the upload progress has changed, and PBS resets producing one seems like a bug?

➤ michael-wb commented:

[~thomas.goyne@mongodb.com] - I was thinking the upload progress notification could be used to wait for a client reset to complete; since there are upload notifications reported when the local changes are recovered, a report of uploadable/uploaded of 0 and an estimate of 1.0 would mean that the client reset is complete and the upload progress is up to date (or nothing needed to be uploaded).

That seems like a very indirect and incorrect way to wait for client resets to complete. Client resets with recovery also shouldn't be producing upload progress notifications unless the bytes to upload changed as part of the recovery.

I would think that the upload of the pending changes that were recovered after the client reset should definitely generate progress notifications, since they still needed to be uploaded and would have produced notifications if the client reset had not happened.

So, based on your recommendation, should the progress notifications never report an upload progress of [uploadble: 0, uploaded: 0, estimate: 0.0 (or 1.0)]?

We send an initial notification on registration, and if that happens to be zero bytes to upload then that's fine. I don't see why we'd ever send another notification with uploadable=0 unless it became non-zero and then was set back to zero.

There's nothing special about the recovered changes wrt to progress notifications. If the recovery doesn't change the size of the changesets waiting to be recovered, I would not expect the existence of a client reset to be observable at all via an upload progress notification.

I don't see why we'd ever send another notification with uploadable=0 unless it became non-zero and then was set back to zero.

Isn't this what's happening during the client reset? The uploadable (and uploaded) values were likely non-zero before the client reset and now they have both been reset back to zero.

FYI - I've posted a message in slack to open the discussion up to the team.

If there's no local changes to recover then a client reset should not be changing uploadable or uploaded. Resetting them to zero is a recent change that I think is incorrect.

➤ michael-wb commented:

This is no longer going to be done - a progress report will not be generated at the end of a client reset if there are no pending local or recovered changes.