Merge pull request #116 from clue-labs/close

WyriHaximus · web-flow · commit 1da4a66c487c · 2017-10-11T19:44:00.000+02:00
Remove event listeners from CompositeStream once closed and remove remove undocumented left-over close event argument
diff --git a/src/CompositeStream.php b/src/CompositeStream.php
@@ -6,9 +6,9 @@
 
 final class CompositeStream extends EventEmitter implements DuplexStreamInterface
 {
-    protected $readable;
-    protected $writable;
-    protected $closed = false;
+    private $readable;
+    private $writable;
+    private $closed = false;
 
     public function __construct(ReadableStreamInterface $readable, WritableStreamInterface $writable)
     {
@@ -77,5 +77,6 @@ public function close()
         $this->writable->close();
 
         $this->emit('close');
+        $this->removeAllListeners();
     }
 }
diff --git a/src/WritableResourceStream.php b/src/WritableResourceStream.php
@@ -92,15 +92,9 @@ public function close()
         $this->writable = false;
         $this->data = '';
 
-        $this->emit('close', array($this));
+        $this->emit('close');
         $this->removeAllListeners();
 
-        $this->handleClose();
-    }
-
-    /** @internal */
-    public function handleClose()
-    {
         if (is_resource($this->stream)) {
             fclose($this->stream);
         }
diff --git a/tests/CompositeStreamTest.php b/tests/CompositeStreamTest.php
@@ -188,6 +188,25 @@ public function itShouldForwardCloseOnlyOnce()
         $writable->close();
     }
 
+    /** @test */
+    public function itShouldForwardCloseAndRemoveAllListeners()
+    {
+        $in = new ThroughStream();
+
+        $composite = new CompositeStream($in, $in);
+        $composite->on('close', $this->expectCallableOnce());
+
+        $this->assertTrue($composite->isReadable());
+        $this->assertTrue($composite->isWritable());
+        $this->assertCount(1, $composite->listeners('close'));
+
+        $composite->close();
+
+        $this->assertFalse($composite->isReadable());
+        $this->assertFalse($composite->isWritable());
+        $this->assertCount(0, $composite->listeners('close'));
+    }
+
     /** @test */
     public function itShouldReceiveForwardedEvents()
     {

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,9 @@`
`6`	`6`
`7`	`7`	`final class CompositeStream extends EventEmitter implements DuplexStreamInterface`
`8`	`8`	`{`
`9`		`- protected $readable;`
`10`		`- protected $writable;`
`11`		`- protected $closed = false;`
	`9`	`+ private $readable;`
	`10`	`+ private $writable;`
	`11`	`+ private $closed = false;`
`12`	`12`
`13`	`13`	`public function __construct(ReadableStreamInterface $readable, WritableStreamInterface $writable)`
`14`	`14`	`{`
`@@ -77,5 +77,6 @@ public function close()`
`77`	`77`	`$this->writable->close();`
`78`	`78`
`79`	`79`	`$this->emit('close');`
	`80`	`+ $this->removeAllListeners();`
`80`	`81`	`}`
`81`	`82`	`}`