8000 Improve memory consumption for cancelled connection attempts by clue · Pull Request #159 · reactphp/socket · GitHub
[go: up one dir, main page]
Skip to content

Improve memory consumption for cancelled connection attempts #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Improve memory consumption for cancelled connection attempts #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/TcpConnector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,11 @@ private function waitForStreamOnce($stream)
$resolve(new Connection($stream, $loop));
}
});
}, function () use ($loop, $stream) {
}, function ($resolve, $reject, $progress) use ($loop, $stream) {
$loop->removeWriteStream($stream);
fclose($stream);

$resolve = $reject = $progress = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this change anything in the memory consumption?

throw new RuntimeException('Cancelled while waiting for TCP/IP connection to be established');
});
}
Expand Down
0