Skip failing test for macOS and windows

SimonFrings · SimonFrings · commit 1370711c92bf · 2021-03-29T11:37:37.000+02:00
diff --git a/tests/FunctionalConnectorTest.php b/tests/FunctionalConnectorTest.php
@@ -40,6 +40,10 @@ public function connectionToTcpServerShouldSucceedWithLocalhost()
      */
     public function testConnectTwiceWithoutHappyEyeBallsOnlySendsSingleDnsQueryDueToLocalDnsCache()
     {
+        if ((DIRECTORY_SEPARATOR === '\\' && PHP_VERSION_ID < 70000) || defined('HHVM_VERSION')) {
+            $this->markTestSkipped('Not supported on windows for PHP versions < 7.0 and legacy HHVM');
+        }
+
         $loop = Factory::create();
 
         $socket = stream_socket_server('udp://127.0.0.1:0', $errno, $errstr, STREAM_SERVER_BIND);
diff --git a/tests/FunctionalSecureServerTest.php b/tests/FunctionalSecureServerTest.php
@@ -15,7 +15,7 @@
 
 class FunctionalSecureServerTest extends TestCase
 {
-    const TIMEOUT = 0.5;
+    const TIMEOUT = 2;
 
     /**
      * @before
@@ -174,7 +174,7 @@ public function testClientUsesTls10WhenCryptoMethodIsExplicitlyConfiguredByClien
         try {
             $client = Block\await($promise, $loop, self::TIMEOUT);
         } catch (\RuntimeException $e) {
-            if (strpos($e->getMessage(), 'no protocols available') !== false) {
+            if (strpos($e->getMessage(), 'no protocols available') !== false || strpos($e->getMessage(), 'routines:state_machine:internal error') !== false) {
                 $this->markTestSkipped('TLS v1.0 not available on this system');
             }
 
diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -101,6 +101,10 @@ public function gettingPlaintextStuffFromEncryptedGoogleShouldNotWork()
 
     public function testConnectingFailsIfConnectorUsesInvalidDnsResolverAddress()
     {
+        if (PHP_OS === 'Darwin') {
+            $this->markTestSkipped('Skipped on macOS due to a bug in reactphp/dns (solved in reactphp/dns#171)');
+        }
+
         $loop = Factory::create();
 
         $factory = new ResolverFactory();
diff --git a/tests/SecureIntegrationTest.php b/tests/SecureIntegrationTest.php
@@ -15,7 +15,7 @@
 
 class SecureIntegrationTest extends TestCase
 {
-    const TIMEOUT = 0.5;
+    const TIMEOUT = 2;
 
     private $loop;
     private $server;

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`class FunctionalSecureServerTest extends TestCase`
`17`	`17`	`{`
`18`		`- const TIMEOUT = 0.5;`
	`18`	`+ const TIMEOUT = 2;`
`19`	`19`
`20`	`20`	`/**`
`21`	`21`	`* @before`
`@@ -174,7 +174,7 @@ public function testClientUsesTls10WhenCryptoMethodIsExplicitlyConfiguredByClien`
`174`	`174`	`try {`
`175`	`175`	`$client = Block\await($promise, $loop, self::TIMEOUT);`
`176`	`176`	`} catch (\RuntimeException $e) {`
`177`		`- if (strpos($e->getMessage(), 'no protocols available') !== false) {`
	`177`	`+ if (strpos($e->getMessage(), 'no protocols available') !== false \|\| strpos($e->getMessage(), 'routines:state_machine:internal error') !== false) {`
`178`	`178`	`$this->markTestSkipped('TLS v1.0 not available on this system');`
`179`	`179`	`}`
`180`	`180`
Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,10 @@ public function gettingPlaintextStuffFromEncryptedGoogleShouldNotWork()`
`101`	`101`
`102`	`102`	`public function testConnectingFailsIfConnectorUsesInvalidDnsResolverAddress()`
`103`	`103`	`{`
	`104`	`+ if (PHP_OS === 'Darwin') {`
	`105`	`+ $this->markTestSkipped('Skipped on macOS due to a bug in reactphp/dns (solved in reactphp/dns#171)');`
	`106`	`+ }`
	`107`	`+`
`104`	`108`	`$loop = Factory::create();`
`105`	`109`
`106`	`110`	`$factory = new ResolverFactory();`