8000 Rename `master` branches for ReactPHP projects · Issue #453 · reactphp/reactphp · GitHub
[go: up one dir, main page]
Skip to content

Rename master branches for ReactPHP projects #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
10 tasks done
SimonFrings opened this issue Mar 10, 2022 · 4 comments
Closed
10 tasks done

Rename master branches for ReactPHP projects #453

SimonFrings opened this issue Mar 10, 2022 · 4 comments
Labels
maintenance

Comments

@SimonFrings
Copy link
Member
SimonFrings commented Mar 10, 2022 •
edited by clue
Loading

I'm suggesting we rename the master branches like already done in reactphp/async, reactphp/filesystem and reactphp/promise.

This would be the case for the following projects:

As @clue already described in reactphp/promise#212:

This has originally been brought up in reactphp/promise#204 by @Seldaek, but instead of defining a branch alias, this PR suggests simply renaming what is currently master to 3.x. This is in line with our existing 2.x and 1.x branches and means we do not have to update any alias definitions once we would start working on a potential future 4.x.

From a consumer's perspective, this means installation is now much easier, as targeting ^3@dev (or 3.x-dev) is semantically more obvious and safer than using dev-master. Additionally, keep in mind that branch names are development artifacts that are subject to change at some point in the future. Once we would decide to rename or delete any of our version branches, the ^3@dev reference would still be valid as it would also match stable versions if we have any ^3 tags at this point (which is safe to assume at this point).
@clue
Copy link
Member
clue commented Mar 11, 2022

Agree that this suggestion makes perfect sense and is perfectly in line with what we did in our other components already with reactphp/promise#212, reactphp/async#29, and reactphp/filesystem#101 already 👍 On top of this, this also helps avoid using the loaded master wording and not only uses more inclusive wording, but also semantically more meaningful names.

I'm happy to update the branch names if there are no objections 👍

@WyriHaximus
Copy link
Member

No objection from me

@clue
Copy link
Member
clue commented Mar 22, 2022

Vote results seem to be pretty unanimous so far, I'll give this a couple of days and will update the branch names if there are no objections 👍

@clue
Copy link
Member
clue commented Mar 31, 2022

Updated all branch names as suggested :shipit:

I'll assume this is resolved and will close this for now, please feel free to report back otherwise 👍

@clue clue closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WyriHaximus @clue @SimonFrings
0