8000 Improve backwards compatibility with Promise v1 · reactphp/http-client@ce9b58b · GitHub
[go: up one dir, main page]
Skip to content

Commit ce9b58b

Browse files
clueclue
committed
Improve backwards compatibility with Promise v1
1 parent 245c40f commit ce9b58b

File tree

3 files changed

+2
-21
lines changed

3 files changed

+2
-21
lines changed

‎composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
"php": ">=5.4.0",
88
"evenement/evenement": "^3.0 || ^2.0",
99
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3",
10+
"react/promise": "^2.1 || ^1.2.1",
1011
"react/socket": "^1.0 || ^0.8.4",
1112
"react/stream": "^1.0 || ^0.7.1",
12-
"react/promise": "~2.2",
1313
"ringcentral/psr7": "^1.2"
1414
},
1515
"require-dev": {

‎src/Request.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ private function writeHead()
5656
$pendingWrites = &$this->pendingWrites;
5757

5858
$promise = $this->connect();
59-
$promise->done(
59+
$promise->then(
6060
function (ConnectionInterface $stream) use ($requestData, &$streamRef, &$stateRef, &$pendingWrites) {
6161
$streamRef = $stream;
6262

‎tests/RequestTest.php

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -272,25 +272,6 @@ public function requestShouldEmitErrorIfUrlHasNoScheme()
272272
$request->end();
273273
}
274274

275-
/**
276-
* @test
277-
* @expectedException Exception
278-
* @expectedExceptionMessage something failed
279-
*/
280-
public function requestDoesNotHideErrors()
281-
{
282-
$requestData = new RequestData('GET', 'http://www.example.com');
283-
$request = new Request($this->connector, $requestData);
284-
285-
$this->rejectedConnectionMock();
286-
287-
$request->on('error', function () {
288-
throw new \Exception('something failed');
289-
});
290-
291-
$request->end();
292-
}
293-
294275
/** @test */
295276
public function postRequestShouldSendAPostRequest()
296277
{

0 commit comments

Comments
 (0)
0