8000 Mark all classes as final to discourage inheritance by clue · Pull Request #131 · reactphp/event-loop · GitHub
[go: up one dir, main page]

Skip to content

Mark all classes as final to discourage inheritance #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

clue
Copy link
Member
@clue clue commented Dec 4, 2017

Classes should be used via composition rather than extension.
This reduces our API footprint and avoids future BC breaks by avoiding
exposing its internal assumptions.

Builds on top of #128

Copy link
Member
@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsor
Copy link
Member
jsor commented Dec 4, 2017

@clue Tests failing 🚨

@WyriHaximus
Copy link
Member

@jsor funny enough before one loop can't be mocked 😂

@clue
Copy link
Member Author
clue commented Dec 4, 2017

Rebased now that #132 is in, this should fix the build error :shipit:

@WyriHaximus
Copy link
Member

Yup looks good 👍

@WyriHaximus WyriHaximus merged commit d5bf858 into reactphp:master Dec 4, 2017
@clue clue deleted the final branch December 4, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0