Move "testTimerIntervalBelowZeroRunsImmediately" from AbstractLoopTest to AbstractTimerTest

PabloKowalczyk · PabloKowalczyk · commit a03212495624 · 2019-08-03T10:01:05.000+02:00
diff --git a/tests/AbstractLoopTest.php b/tests/AbstractLoopTest.php
@@ -589,13 +589,6 @@ public function testSignalsKeepTheLoopRunningAndRemovingItStopsTheLoop()
         $this->assertRunFasterThan(1.6);
     }
 
-    public function testTimerIntervalBelowZeroRunsImmediately()
-    {
-        $this->loop->addTimer(-1, function () {});
-
-        $this->assertRunFasterThan(0.002);
-    }
-
     public function testTimerIntervalCanBeFarInFuture()
     {
         // Maximum interval for ExtUvLoop implementation
diff --git a/tests/Timer/AbstractTimerTest.php b/tests/Timer/AbstractTimerTest.php
@@ -137,4 +137,22 @@ public function testMinimumIntervalOneMicrosecond()
 
         $this->assertEquals(0.000001, $timer->getInterval());
     }
+
+    public function testTimerIntervalBelowZeroRunsImmediately()
+    {
+        $loop = $this->createLoop();
+        $start = 0;
+        $loop->addTimer(
+            -1,
+            static function () use (&$start) {
+                $start = \microtime(true);
+            }
+        );
+
+        $loop->run();
+        $end = \microtime(true);
+
+        // 1ms should be enough even on slow machines
+        $this->assertLessThan(0.001, $end - $start);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -589,13 +589,6 @@ public function testSignalsKeepTheLoopRunningAndRemovingItStopsTheLoop()`
`589`	`589`	`$this->assertRunFasterThan(1.6);`
`590`	`590`	`}`
`591`	`591`
`592`		`- public function testTimerIntervalBelowZeroRunsImmediately()`
`593`		`- {`
`594`		`- $this->loop->addTimer(-1, function () {});`
`595`		`-`
`596`		`- $this->assertRunFasterThan(0.002);`
`597`		`- }`
`598`		`-`
`599`	`592`	`public function testTimerIntervalCanBeFarInFuture()`
`600`	`593`	`{`
`601`	`594`	`// Maximum interval for ExtUvLoop implementation`