Fix failing test cases due to inaccurate timers

clue · clue · commit 51f0e6936ea3 · 2019-12-23T16:10:09.000+01:00
diff --git a/tests/Timer/AbstractTimerTest.php b/tests/Timer/AbstractTimerTest.php
@@ -22,9 +22,6 @@ public function testAddTimerReturnsNonPeriodicTimerInstance()
         $this->assertFalse($timer->isPeriodic());
     }
 
-    /**
-     * @depends testPlatformHasHighAccuracy
-     */
     public function testAddTimerWillBeInvokedOnceAndBlocksLoopWhenRunning()
     {
         // Make no strict assumptions about actual time interval. Common
@@ -46,14 +43,15 @@ public function testAddTimerWillBeInvokedOnceAndBlocksLoopWhenRunning()
 
         $loop = $this->createLoop();
 
-        $loop->addTimer(0.001, $this->expectCallableOnce());
+        $loop->addTimer(0.002, $this->expectCallableOnce());
 
         $start = microtime(true);
         $loop->run();
         $end = microtime(true);
 
+        // 1 invocation should take 2ms (± 1ms due to timer inaccuracies)
         $this->assertGreaterThanOrEqual(0.001, $end - $start);
-        $this->assertLessThan(0.002, $end - $start);
+        $this->assertLessThan(0.003, $end - $start);
     }
 
     public function testAddPeriodicTimerReturnsPeriodicTimerInstance()
@@ -122,10 +120,10 @@ public function testAddPeriodicTimerCancelsItself()
 
         $this->assertEquals(5, $i);
 
-        // make no strict assumptions about time interval.
-        // 5 invocations must take at least 0.005s (5ms) and should not take
-        // longer than 0.1s for slower loops.
-        $this->assertGreaterThanOrEqual(0.005, $end - $start);
+        // 5 invocations should take 5ms (± 1ms due to timer inaccuracies)
+        // make no strict assumptions about time interval, must at least take 4ms
+        // and should not take longer than 0.1s for slower loops.
+        $this->assertGreaterThanOrEqual(0.004, $end - $start);
         $this->assertLessThan(0.1, $end - $start);
     }
 
