Improve PHP 8.4+ support by avoiding implicitly nullable types

clue · clue · commit 0409cb2f841a · 2024-05-24T16:04:22.000+02:00
diff --git a/composer.json b/composer.json
@@ -28,7 +28,7 @@
     "require": {
         "php": ">=8.1",
         "react/event-loop": "^1.2",
-        "react/promise": "^3.0 || ^2.8 || ^1.2.1"
+        "react/promise": "^3.2 || ^2.8 || ^1.2.1"
     },
     "require-dev": {
         "phpstan/phpstan": "1.10.39",
diff --git a/src/FiberFactory.php b/src/FiberFactory.php
@@ -22,7 +22,7 @@ public static function create(): FiberInterface
         return (self::factory())();
     }
 
-    public static function factory(\Closure $factory = null): \Closure
+    public static function factory(?\Closure $factory = null): \Closure
     {
         if ($factory !== null) {
             self::$factory = $factory;

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public static function create(): FiberInterface`
`22`	`22`	`return (self::factory())();`
`23`	`23`	`}`
`24`	`24`
`25`		`- public static function factory(\Closure $factory = null): \Closure`
	`25`	`+ public static function factory(?\Closure $factory = null): \Closure`
`26`	`26`	`{`
`27`	`27`	`if ($factory !== null) {`
`28`	`28`	`self::$factory = $factory;`