8000 `use_query` does not properly pre-fetch some model fields · Issue #110 · reactive-python/reactpy-django · GitHub
[go: up one dir, main page]
Skip to content

use_query does not properly pre-fetch some model fields #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Nov 15, 2022 · 3 comments · Fixed by #112
Closed

use_query does not properly pre-fetch some model fields #110

Archmonger opened this issue Nov 15, 2022 · 3 comments · Fixed by #112
Labels
priority: 2 (moderate)

Comments

@Archmonger
Copy link
Contributor
Archmonger commented Nov 15, 2022 •
edited
Loading

Current Situation

ManyToMany fields are not properly prefetched, thus causing SynchronousOnlyOperation exceptions.

For example, in this case.

Proposed Actions

Determine why the current prefetch logic doesn't work on this use case.
@rmorshea
Copy link
Contributor

It looks like one-to-many and many-to-many relationships return relationship managers. Should be as simple as calling the get_queryset() and recursively resolving values.

@Archmonger Archmonger linked a pull request Nov 15, 2022 that will close this issue
use_query prefetching for ManyToMany and ManyToOne fields #112
Merged
3 tasks
@rmorshea
Copy link
Contributor

Ok, as discovered in that draft PR, get_queryset() does not actually cache anything. After doing a bit of research, it seems like this is something that needs to be managed by users with prefetch_related or select_related. There's a prefect_related_objects function that can work on model instances rather than queries, but I'm not really sure how that could be used automatically.

@Archmonger
Copy link
Contributor Author

Looks like prefect_related_objects was exactly what we needed.

@rmorshea rmorshea mentioned this issue Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 2 (moderate)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use_query prefetching for ManyToMany and ManyToOne fields Archmonger/reactpy-django
2 participants
@rmorshea @Archmonger
0