8000 fix(Offcanvas): do not trigger Navbar onToggle when closing by kyletsang · Pull Request #6829 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]
Skip to content

fix(Offcanvas): do not trigger Navbar onToggle when closing #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(Offcanvas): do not trigger Navbar onToggle when closing #6829

merged 1 commit into from
Jul 23, 2024

Conversation

kyletsang
Copy link
Member

Fixes #6827
Closes #6828

The Navbar context should've been used in NavbarOffcanvas instead of the regular Offcanvas

@kyletsang kyletsang requested a review from jquense July 12, 2024 05:02
@benhuangbmj
Copy link

@kyletsang Thank you for drawing attention to #6827 . I do enjoy your solution!

@kyletsang kyletsang merged commit 6836e99 into master Jul 23, 2024
10 checks passed
@kyletsang kyletsang deleted the fix-offcanvas-toggle branch July 23, 2024 06:20
@it21222672 it21222672 mentioned this pull request Oct 18, 2024
Open
@sswietoniowski sswietoniowski mentioned this pull request Oct 22, 2024
Merged
@mooseburgr mooseburgr mentioned this pull request Oct 25, 2024
Closed
@Victor-Nash Victor-Nash mentioned this pull request Oct 27, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Oct 29, 2024
Open
@samrouth1234 samrouth1234 mentioned this pull request Oct 29, 2024
Open
@thedignifiedco thedignifiedco mentioned this pull request Oct 31, 2024
Open
@scudette scudette mentioned this pull request Oct 31, 2024
Closed
@leoo1992 leoo1992 mentioned this pull request Oct 31, 2024
Open
@samrouth1234 samrouth1234 mentioned this pull request Nov 1, 2024
Open
@han20011222 han20011222 mentioned this pull request Nov 1, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 3, 2024
Open
@zxcv32 zxcv32 mentioned this pull request Nov 4, 2024
Open
@MadisonEvans94 MadisonEvans94 mentioned this pull request Nov 5, 2024
Open
@zxcv32 zxcv32 mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense Awaiting requested review from jquense

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing out an Offcanvas in a Navbar triggering the Navbar.Toggle
2 participants
@kyletsang @benhuangbmj
0