bug symfony#59160 [BeanstalkMessenger] Round delay to an integer to avoid deprecation warning (plantas)

fabpot · fabpot · commit c78a9ec1a901 · 2024-12-11T07:49:27.000+01:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [BeanstalkMessenger] Round delay to an integer to avoid deprecation warning | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | - | License | MIT https://github.com/pheanstalk/pheanstalk/blob/1459f2f62dddfe28902e0584708417dddd79bd70/src/Pheanstalk.php#L223-L228 The `Pheanstalk::put()` method expects the `$delay` parameter to be an integer. However, during the conversion from milliseconds to seconds, it is passed as a float. This triggers a deprecation warning: 'Deprecated: Implicit conversion from float to int loses precision.' Commits ------- 99aae50 [BeanstalkMessenger] Round delay to an integer to avoid deprecation warning
diff --git a/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Tests/Transport/ConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Tests/Transport/ConnectionTest.php
@@ -330,4 +330,25 @@ public function testSendWhenABeanstalkdExceptionOccurs()
 
         $connection->send($body, $headers, $delay);
     }
+
+    public function testSendWithRoundedDelay()
+    {
+        $tube = 'xyz';
+        $body = 'foo';
+        $headers = ['test' => 'bar'];
+        $delay = 920;
+        $expectedDelay = 0;
+
+        $client = $this->createMock(PheanstalkInterface::class);
+        $client->expects($this->once())->method('useTube')->with($tube)->willReturn($client);
+        $client->expects($this->once())->method('put')->with(
+            $this->anything(),
+            $this->anything(),
+            $expectedDelay,
+            $this->anything(),
+        );
+
+        $connection = new Connection(['tube_name' => $tube], $client);
+        $connection->send($body, $headers, $delay);
+    }
 }
diff --git a/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Beanstalkd/Transport/Connection.php
@@ -123,7 +123,7 @@ public function send(string $body, array $headers, int $delay = 0): string
             $job = $this->client->useTube($this->tube)->put(
                 $message,
                 PheanstalkInterface::DEFAULT_PRIORITY,
-                $delay / 1000,
+                (int) ($delay / 1000),
                 $this->ttr
             );
         } catch (Exception $exception) {
