Fix an infinite recursion issue by only checking loc async chunks in runtime chunks.

iclanton · iclanton · commit b365b1f2d452 · 2020-03-27T18:14:47.000-07:00
diff --git a/webpack/localization-plugin/src/LocalizationPlugin.ts b/webpack/localization-plugin/src/LocalizationPlugin.ts
@@ -646,7 +646,8 @@ export class LocalizationPlugin implements Webpack.Plugin {
         }
       }
 
-      if (!chunkHasAnyLocModules) {
+      // Check async chunks if this is a runtime chunk and we haven't directly found any localized modules
+      if (chunk.hasRuntime() && !chunkHasAnyLocModules) {
         for (const asyncChunk of chunk.getAllAsyncChunks()) {
           if (this._chunkHasLocalizedModules(asyncChunk)) {
             chunkHasAnyLocModules = true;

Original file line number	Diff line number	Diff line change
`@@ -646,7 +646,8 @@ export class LocalizationPlugin implements Webpack.Plugin {`
`646`	`646`	`}`
`647`	`647`	`}`
`648`	`648`
`649`		`- if (!chunkHasAnyLocModules) {`
	`649`	`+ // Check async chunks if this is a runtime chunk and we haven't directly found any localized modules`
	`650`	`+ if (chunk.hasRuntime() && !chunkHasAnyLocModules) {`
`650`	`651`	`for (const asyncChunk of chunk.getAllAsyncChunks()) {`
`651`	`652`	`if (this._chunkHasLocalizedModules(asyncChunk)) {`
`652`	`653`	`chunkHasAnyLocModules = true;`