8000 [rush] Clean up some unhelpful incremental build logging messages. (#… · rbuckton/rushstack@4fb028d · GitHub
[go: up one dir, main page]

Skip to content

Commit 4fb028d

Browse files
author
Claudia Sun
authored
[rush] Clean up some unhelpful incremental build logging messages. (microsoft#1799)
* delete redundant rush rebuild output * rush change * minor fix
1 parent 82476f4 commit 4fb028d

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

apps/rush-lib/src/logic/taskRunner/ProjectTask.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ export interface IProjectTaskOptions {
3131
function _areShallowEqual(object1: JsonObject, object2: JsonObject, writer: ITaskWriter): boolean {
3232
for (const n in object1) {
3333
if (!(n in object2) || object1[n] !== object2[n]) {
34-
writer.writeLine(`Found mismatch: "${n}": "${object1[n]}" !== "${object2[n]}"`);
34+
// writer.writeLine(`Found mismatch: "${n}": "${object1[n]}" !== "${object2[n]}"`);
3535
return false;
3636
}
3737
}
3838
for (const n in object2) {
3939
if (!(n in object1)) {
40-
writer.writeLine(`Found new prop in obj2: "${n}" value="${object2[n]}"`);
40+
// writer.writeLine(`Found new prop in obj2: "${n}" value="${object2[n]}"`);
10000 4141
return false;
4242
}
4343
}
@@ -69,7 +69,7 @@ export class ProjectTask implements ITaskDefinition {
6969
this.isIncrementalBuildAllowed = options.isIncrementalBuildAllowed;
7070
this._packageChangeAnalyzer = options.packageChangeAnalyzer;
7171
this._packageDepsFilename = options.packageDepsFilename;
72-
}
72+
}
7373

7474
public execute(writer: ITaskWriter): Promise<TaskStatus> {
7575
try {
@@ -132,7 +132,7 @@ export class ProjectTask implements ITaskDefinition {
132132
lastPackageDeps &&
133133
currentPackageDeps &&
134134
(currentPackageDeps.arguments === lastPackageDeps.arguments &&
135-
_areShallowEqual(currentPackageDeps.files, lastPackageDeps.files, writer))
135+
_areShallowEqual(currentPackageDeps.files, lastPackageDeps.files, writer))
136136
)
137137
);
138138

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/rush",
5+
"comment": "Remove some misleading log output for \"rush build\" (GitHub #1733)",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@microsoft/rush",
10+
"email": "zhas@microsoft.com"
11+
}

0 commit comments

Comments
 (0)
0