10BC0 Comparing main...v0.4.3 · raystack/firehose · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: raystack/firehose
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: raystack/firehose
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.3
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 22, 2022

  1. fix: Adding service provider configuration files to fix the grpc sink…

    … exception "Could not find policy 'pick_first'" (#203)
    
    In the current implementation, the gRPC client chooses default LoadBalancerProvider ('pick_first') and default NameResolverProvider(DNS). The implementation classes PickFirstLoadBalancerProvider and DnsNameResolverProvider respectively are missing.
    
    We can handle the issue with the including implementation classes through service provider configuration files.
    * SPI io.grpc.LoadBalancerProvider: io.grpc.internal.PickFirstLoadBalancerProvider
    * SPI io.grpc.NameResolverProvider: io.grpc.internal.DnsNameResolverProvider
    
    Co-authored-by: Shreyansh <shreyansh.sangolli@gojek.com>
    2 people authored and lavkesh committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    88adc36 View commit details
    Browse the repository at this point in the history
  2. chore: version bump

    lavkesh committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7fc9c82 View commit details
    Browse the repository at this point in the history
Loading
0