Letting postInstallScript fails gracefully

Federico Fissore · Federico Fissore · commit 99fa19c36c84 · 2015-04-02T11:20:53.000+02:00
diff --git a/arduino-core/src/cc/arduino/contributions/packages/ContributionInstaller.java b/arduino-core/src/cc/arduino/contributions/packages/ContributionInstaller.java
@@ -192,10 +192,16 @@ public boolean apply(File file) {
     ByteArrayOutputStream stderr = new ByteArrayOutputStream();
     Executor executor = new CollectStdOutStdErrExecutor(stdout, stderr);
     executor.setWorkingDirectory(folder);
-    executor.execute(new CommandLine(postInstallScript));
+    executor.setExitValues(null);
+    int exitValue = executor.execute(new CommandLine(postInstallScript));
+    executor.setExitValues(new int[0]);
 
     System.out.write(stdout.toByteArray());
     System.err.write(stderr.toByteArray());
+
+    if (executor.isFailure(exitValue)) {
+      throw new IOException();
+    }
   }
 
   public List<String> remove(ContributedPlatform platform) {
