Fix pin change interrupt handling (esp8266#322)

igrr · igrr · commit 6061d9b1f466 · 2015-06-15T22:50:44.000+03:00
diff --git a/hardware/esp8266com/esp8266/cores/esp8266/core_esp8266_wiring_digital.c b/hardware/esp8266com/esp8266/cores/esp8266/core_esp8266_wiring_digital.c
@@ -121,7 +121,11 @@ void interrupt_handler(void *arg) {
     while(!(changedbits & (1 << i))) i++;
     changedbits &= ~(1 << i);
     interrupt_handler_t *handler = &interrupt_handlers[i];
-    if(((handler->mode & 1) == digitalRead(i)) && handler->fn) handler->fn();
+    if (handler->fn && 
+        (handler->mode == CHANGE || 
+         (handler->mode & 1) == digitalRead(i))) {
+      handler->fn();
+    }
   }
   ETS_GPIO_INTR_ENABLE();
 }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,11 @@ void interrupt_handler(void *arg) {`
`121`	`121`	`while(!(changedbits & (1 << i))) i++;`
`122`	`122`	`changedbits &= ~(1 << i);`
`123`	`123`	`interrupt_handler_t *handler = &interrupt_handlers[i];`
`124`		`- if(((handler->mode & 1) == digitalRead(i)) && handler->fn) handler->fn();`
	`124`	`+ if (handler->fn &&`
	`125`	`+ (handler->mode == CHANGE \|\|`
	`126`	`+ (handler->mode & 1) == digitalRead(i))) {`
	`127`	`+ handler->fn();`
	`128`	`+ }`
`125`	`129`	`}`
`126`	`130`	`ETS_GPIO_INTR_ENABLE();`
`127`	`131`	`}`