fix: do not emit update:value in case of 'multiple' attribute coreui#64

woothu · woothu · commit 73d2b3f874da · 2020-03-05T15:43:59.000+01:00
diff --git a/src/components/form/CSelect.vue b/src/components/form/CSelect.vue
@@ -220,6 +220,7 @@ export default {
 
   methods: {
     onSelect (e) {
+      if (this.$attrs.multiple !== undefined) return
       const optionIndex = e.target.selectedOptions[0].dataset.key
       const option = this.options[optionIndex]
       const value = option.value || option
diff --git a/src/components/form/tests/CSelect.spec.js b/src/components/form/tests/CSelect.spec.js
@@ -42,6 +42,14 @@ const customWrapper = mount(Component, {
     prepend: 'prepended'
   }
 })
+const wrapperMultiple = mount(Component, {
+  propsData: {
+    options: ['Option 1', 'Option 2', 'Option 3'],
+  },
+  attrs: {
+    multiple: true
+  }
+})
 
 describe(ComponentName, () => {
   it('has a name', () => {
@@ -62,4 +70,10 @@ describe(ComponentName, () => {
     select.trigger('input')
     expect(customWrapper.emitted()['update:value']).toBeTruthy()
   })
+  it('not emit update event on multiple select', () => {
+    const select = wrapperMultiple.find('select')
+    select.element.value = 'Option 2'
+    select.trigger('input')
+    expect(wrapperMultiple.emitted()['update:value']).not.toBeTruthy()
+  })
 })
