8000 Tweaks to PIO clkdiv-setting code by lurch · Pull Request #254 · raspberrypi/pico-sdk · GitHub
[go: up one dir, main page]

Skip to content

Tweaks to PIO clkdiv-setting code #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

lurch
Copy link
Contributor
@lurch lurch commented Mar 13, 2021
  • refactor to reduce duplication
  • add extra param-validation

You get "unexpected results" if the divider is set too big 😉 micropython/micropython#7025

@lurch
Copy link
Contributor Author
lurch commented Mar 13, 2021

The diff looks worse than it actually is because I swapped around the order of a couple of functions.

 - refactor to reduce duplication
 - add extra param-validation
@lurch lurch changed the base branch from develop to develop-1.1.1 March 19, 2021 14:31
@lurch
Copy link
Contributor Author
lurch commented Mar 19, 2021

Manually "rebased" to develop-1.1.1 and force-pushed.

@kilograham kilograham merged commit 0c941d9 into raspberrypi:develop-1.1.1 Mar 24, 2021
@lurch lurch deleted the pio_clkdiv branch March 24, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0