8000 Need FIFO joining example · Issue #27 · raspberrypi/pico-micropython-examples · GitHub
[go: up one dir, main page]
Skip to content
8000

Need FIFO joining example #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IndustrialMuffin opened this issue Mar 31, 2021 · 10 comments
Closed

Need FIFO joining example #27

IndustrialMuffin opened this issue Mar 31, 2021 · 10 comments

Comments

@IndustrialMuffin
Copy link

While going through the RP2040 Datasheet https://datasheets.raspberrypi.org/rp2040/rp2040-datasheet.pdf Chapter 3 PIO, section 3.5 Functional Details, then looking for documentation and examples of FIFO joining in micropython, the only thing I've found is https://forum.micropython.org/viewtopic.php?t=9814&p=54996

It'd be convenient to have an example of FIFO joining here with all these other wonderful examples.
@lurch
Copy link
Contributor
lurch commented Apr 1, 2021

That forum thread you linked to says "MicroPython doesn't provide an API for this (yet)."

AFAIK the examples in this repo only illustrate using MicroPython APIs; so without MicroPython API support for joining PIO FIFOs, there won't be any pico-micropython-examples showing how to join PIO FIFOs.

@IndustrialMuffin
Copy link
Author

Seems like a fairly valid point lurch. Now it looks like fifo_join support has recently been added to MicroPython. Gotta figure out how to use it and test it out. fifo_join support added here

@lurch
Copy link
Contributor
lurch 8000 commented Apr 21, 2021

If you do figure it out, Pull Requests are always welcome 🙂

@kevindawson
Copy link

@lurch @IndustrialMuffin

from MicroPython GitHub

issue:

  • rp2 PIO: Allow merging Tx/Rx FIFOs together #6854

pull:

  • rp2/rp2_pio: Add fifo_join support for PIO. #7093

@lurch
Copy link
Contributor
lurch commented May 2, 2021

@kevindawson Yes, that's related to @IndustrialMuffin 's "it looks like fifo_join support has recently been added to MicroPython" comment.

My "Pull Requests are always welcome" comment was WRT to adding an example of using FIFO joining to this pico-micropython-examples repo. Unfortunately all the RPi engineers are too busy with other stuff to have time to add new example code.

@kevindawson
Copy link

@lurch
from MicroPython GitHub

example: pio_uart_rx.py

@lurch
Copy link
Contributor
lurch commented May 3, 2021

I'm not sure if there's value in duplicating example-code between multiple repos? 🤷 (it can often lead to the situation where fixes made in one version don't appear in the other version)

Sounds like a decision for @aallan to make 😃

@kevindawson
Copy link

@lurch with all my reading around - example I had seen ;)
Please do not duplicate
I think it would be better just to have links

@lurch
Copy link
Contributor
lurch commented May 3, 2021

I think it would be better just to have links

Good idea, see #34 🙂

@kevindawson
Copy link

@lurch Cool ;)
@IndustrialMuffin if your a happy bunny now, please close.

@lurch lurch mentioned this issue May 3, 2021
Merged
@megazhuk megazhuk mentioned this issue Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lurch @kevindawson @IndustrialMuffin
0