Closed
Description
Describe the bug
In commit 9ffaf55e, the change switches between analog 2x2 binning and the 2x2 binning based on whether its an 8-bit codec or 10-bit one. But in commit 7a41d0f the rate factor is set based on mode.
So in this case of a 10bit 640x480 video capture, the normal 2x2 binning is used but with rate_factor set to 2.
I believe this causes the video at high FPS to be "corrupted"
t640x480x10x200.mp4
as compared to the same at 8bit codec or 10-bit codec with lower FPS
t640x480x8x200.mp4
t640x480x10x100.mp4
Steps to reproduce the behaviour
libcamera-vid --level 4.2 --framerate 200 --buffer-count 10 --mode 640:480:10:P --save-pts t640x480x10x200.pts -o t640x480x10x200.h264 -t 3000 --denoise cdn_off -n
vs
libcamera-vid --level 4.2 --framerate 200 --buffer-count 10 --mode 640:480:8:P --save-pts t640x480x8x200.pts -o t640x480x8x200.h264 -t 3000 --denoise cdn_off -n
or
libcamera-vid --level 4.2 --framerate 100 --buffer-count 10 --mode 640:480:10:P --save-pts t640x480x10x100.pts -o t640x480x10x100.h264 -t 3000 --denoise cdn_off -n
Device (s)
Raspberry Pi 4 Mod. B
System
cat /etc/rpi-issue
Raspberry Pi reference 2023-05-03
Generated using pi-gen, https://github.com/RPi-Distro/pi-gen, 7c750947a959fb626a70c09fd17c65815df192ac, stage2
vcgencmd version
Mar 17 2023 10:50:39
Copyright (c) 2012 Broadcom
version 82f3750a65fadae9a38077e3c2e217ad158c8d54 (clean) (release) (start)
uname -a
Linux nvrpi-2 6.1.31-v8+ #4 SMP PREEMPT Tue Jun 6 20:34:04 +08 2023 aarch64 GNU/Linux
Logs
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
No labels