Refactor to print in __str__

Kevin Burke · Kevin Burke · commit 950c9ca2d994 · 2014-02-25T16:32:03.000-08:00
diff --git a/twilio/__init__.py b/twilio/__init__.py
@@ -1,3 +1,7 @@
+import sys
+
+from six import u
+
 __version_info__ = ('3', '6', '5')
 __version__ = '.'.join(__version_info__)
 
@@ -12,17 +16,57 @@ class TwilioRestException(TwilioException):
     :param int status: the HTTP status that was returned for the exception
     :param str uri: The URI that caused the exception
     :param str msg: A human-readable message for the error
+    :param str method: The HTTP method used to make the request
     :param int|None code: A Twilio-specific error code for the error. This is
          not available for all errors.
     """
 
     # XXX: Move this to the twilio.rest folder
 
-    def __init__(self, status, uri, msg="", code=None):
+    def __init__(self, status, uri, msg="", code=None, method='GET'):
         self.uri = uri
         self.status = status
         self.msg = msg
         self.code = code
+        self.method = method
 
     def __str__(self):
-        return "HTTP ERROR %s: %s \n %s" % (self.status, self.msg, self.uri)
+        """ Try to pretty-print the exception, if this is going on screen. """
+
+        def red(words):
+            return u("\033[31m\033[49m%s\033[0m") % words
+
+        def white(words):
+            return u("\033[37m\033[49m%s\033[0m") % words
+
+        def blue(words):
+            return u("\033[34m\033[49m%s\033[0m") % words
+
+        def teal(words):
+            return u("\033[36m\033[49m%s\033[0m") % words
+
+        def get_uri(code):
+            return "https://www.twilio.com/docs/errors/{}".format(code)
+
+        # If it makes sense to print a human readable error message, try to
+        # do it. The one problem is that someone might catch this error and
+        # try to display the message from it to an end user.
+        if hasattr(sys.stderr, 'isatty') and sys.stderr.isatty():
+            msg = (
+                "\n{red_error} {request_was}\n\n{http_line}"
+                "\n\n{twilio_returned}\n\n{message}\n".format(
+                    red_error=red("HTTP Error"),
+                    request_was=white("Your request was:"),
+                    http_line=teal("%s %s" % (self.method, self.uri)),
+                    twilio_returned=white(
+                        "Twilio returned the following information:"),
+                    message=blue(str(self.msg))
+                ))
+            if self.code:
+                msg = "".join([msg, "\n{more_info}\n\n{uri}\n\n".format(
+                    more_info=white("More information may be available here:"),
+                    uri=blue(get_uri(self.code))),
+                ])
+            return msg
+        else:
+            return "HTTP {} error: {}".format(self.status, self.msg)
diff --git a/twilio/rest/resources/base.py b/twilio/rest/resources/base.py
@@ -146,38 +146,8 @@ def make_twilio_request(method, uri, **kwargs):
             code = None
             message = resp.content
 
-        def red(msg):
-            return u("\033[31m\033[49m%s\033[0m") % msg
-
-        def white(msg):
-            return u("\033[37m\033[49m%s\033[0m") % msg
-
-        def blue(msg):
-            return u("\033[34m\033[49m%s\033[0m") % msg
-
-        def orange(msg):
-            return u("\033[33m\033[49m%s\033[0m") % msg
-
-        def teal(msg):
-            return u("\033[36m\033[49m%s\033[0m") % msg
-
-        # If it makes sense to print a human readable error message, try to do
-        # it. The one problem is that someone might catch this error and try to
-        # display the message from it to an end user.
-        if hasattr(sys.stderr, 'isatty') and sys.stderr.isatty():
-            msg = red("\nHTTP Error. ")
-            msg += white("Your request was:\n\n")
-            msg += teal("%s %s" % (method, uri))
-            msg += white("\n\nTwilio returned the following information:")
-            msg += blue("\n\n" + str(message) + "\n")
-            if code:
-                msg += white("\nMore information may be available here:\n\n")
-                msg += blue("https://www.twilio.com/docs/errors/%s" % code)
-                msg += "\n\n"
-        else:
-            msg = message
-
-        raise TwilioRestException(resp.status_code, resp.url, msg, code)
+        raise TwilioRestException(status=resp.status_code, method=method,
+                                  uri=resp.url, msg=message, code=code)
 
     return resp
 
