Remove LLVMDisassembler_Option_SetInstrComments for now

Gabriel Corona · Gabriel Corona · commit 8e7c39c7739d · 2019-08-01T23:38:21.000+02:00
It's not super useful and triggers a bug in LLVM (the process is stuck
in LLVM and consumes a lot of memory) for some instructions such as:

    66 0f 6c c0             punpcklqdq %xmm0,%xmm0

or

    66 0f 70 c8 4e          pshufd xmm1, xmm0, 0x4e
diff --git a/src/Disassembler.cpp b/src/Disassembler.cpp
@@ -59,9 +59,7 @@ Disassembler::Disassembler(Process& process) : process_(&process)
     throw std::runtime_error("Could not intialize LLVM disassembler");
   }
   LLVMSetDisasmOptions(this->disassembler_,
-    LLVMDisassembler_Option_SetInstrComments
-    | LLVMDisassembler_Option_PrintLatency
-    );
+    LLVMDisassembler_Option_PrintLatency);
 }
 
 Disassembler::~Disassembler()

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,7 @@ Disassembler::Disassembler(Process& process) : process_(&process)`
`59`	`59`	`throw std::runtime_error("Could not intialize LLVM disassembler");`
`60`	`60`	`}`
`61`	`61`	`LLVMSetDisasmOptions(this->disassembler_,`
`62`		`- LLVMDisassembler_Option_SetInstrComments`
`63`		`- \| LLVMDisassembler_Option_PrintLatency`
`64`		`- );`
	`62`	`+ LLVMDisassembler_Option_PrintLatency);`
`65`	`63`	`}`
`66`	`64`
`67`	`65`	`Disassembler::~Disassembler()`