Add InvalidProperty test and fix the travis error resulting from pytype not being supported in python 3.4

dbieber · copybara-github · commit 04e2434001e8 · 2020-02-25T17:43:25.000-08:00
PiperOrigin-RevId: 297245710
Change-Id: I0b0f6110f2aeb1951a585be3532e8d49c22e41c7
diff --git a/.travis.yml b/.travis.yml
@@ -23,12 +23,15 @@ script:
   - pip install ipython
   - python -m pytest  # Now run the tests with IPython.
   - pylint fire --ignore=test_components_py3.py,parser_fuzz_test.py,console
-  - pip install pytype
+  - if [[ $TRAVIS_PYTHON_VERSION != 3.4 ]]; then
+      pip install pytype;
+    fi
   # Run type-checking, excluding files that define or use py3 features in py2.
   - if [[ $TRAVIS_PYTHON_VERSION == 2.7 ]]; then
       pytype -x
         fire/fire_test.py
         fire/inspectutils_test.py
         fire/test_components_py3.py;
-    else
-      pytype; fi
+    elif [[ $TRAVIS_PYTHON_VERSION != 3.4 ]]; then
+      pytype;
+    fi
diff --git a/fire/fire_test.py b/fire/fire_test.py
@@ -708,6 +708,10 @@ def testClassWithDefaultMethod(self):
         fire.Fire(tc.DefaultMethod, command=['double', '10']), 20
     )
 
+  def testClassWithInvalidProperty(self):
+    self.assertEqual(
+        fire.Fire(tc.InvalidProperty, command=['double', '10']), 20
+    )
 
 if __name__ == '__main__':
   testutils.main()
diff --git a/fire/test_components.py b/fire/test_components.py
@@ -509,3 +509,13 @@ def __getattr__(self, name):
     def _missing():
       return 'Undefined function'
     return _missing
+
+
+class InvalidProperty(object):
+
+  def double(self, number):
+    return 2 * number
+
+  @property
+  def prop(self):
+    raise ValueError('test')

Original file line number	Diff line number	Diff line change
`@@ -708,6 +708,10 @@ def testClassWithDefaultMethod(self):`
`708`	`708`	`fire.Fire(tc.DefaultMethod, command=['double', '10']), 20`
`709`	`709`	`)`
`710`	`710`
	`711`	`+ def testClassWithInvalidProperty(self):`
	`712`	`+ self.assertEqual(`
	`713`	`+ fire.Fire(tc.InvalidProperty, command=['double', '10']), 20`
	`714`	`+ )`
`711`	`715`
`712`	`716`	`if __name__ == '__main__':`
`713`	`717`	`testutils.main()`