Optimize reading huge packet (PyMySQL#779)

Deneby67 · methane · commit 3539f87ed59b · 2019-02-05T16:55:38.000+09:00
diff --git a/pymysql/connections.py b/pymysql/connections.py
@@ -638,7 +638,7 @@ def _read_packet(self, packet_type=MysqlPacket):
         :raise OperationalError: If the connection to the MySQL server is lost.
         :raise InternalError: If the packet sequence number is wrong.
         """
-        buff = b''
+        buff = bytearray()
         while True:
             packet_header = self._read_bytes(4)
             #if DEBUG: dump_packet(packet_header)
@@ -666,7 +666,7 @@ def _read_packet(self, packet_type=MysqlPacket):
             if bytes_to_read < MAX_PACKET_LEN:
                 break
 
-        packet = packet_type(buff, self.encoding)
+        packet = packet_type(bytes(buff), self.encoding)
         packet.check_error()
         return packet
 
