Prevent creation of a Signature with an empty email

nulltoken · nulltoken · commit 381428ea2e6d · 2014-11-04T10:00:06.000-08:00
diff --git a/LibGit2Sharp.Tests/SignatureFixture.cs b/LibGit2Sharp.Tests/SignatureFixture.cs
@@ -35,13 +35,7 @@ public void CreatingASignatureWithBadParamsThrows()
             Assert.Throws<ArgumentNullException>(() => new Signature(null, "me@there.com", DateTimeOffset.Now));
             Assert.Throws<ArgumentException>(() => new Signature(string.Empty, "me@there.com", DateTimeOffset.Now));
             Assert.Throws<ArgumentNullException>(() => new Signature("Me", null, DateTimeOffset.Now));
-        }
-
-        [Fact]
-        public void CanCreateASignatureWithAnEmptyEmail()
-        {
-            var sig = new Signature("Me", string.Empty, DateTimeOffset.Now);
-            Assert.Equal(string.Empty, sig.Email);
+            Assert.Throws<ArgumentException>(() => new Signature("Me", string.Empty, DateTimeOffset.Now));
         }
     }
 }
diff --git a/LibGit2Sharp/Signature.cs b/LibGit2Sharp/Signature.cs
@@ -36,7 +36,7 @@ internal Signature(IntPtr signaturePtr)
         public Signature(string name, string email, DateTimeOffset when)
         {
             Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNull(email, "email");
+            Ensure.ArgumentNotNullOrEmptyString(email, "email");
             Ensure.ArgumentDoesNotContainZeroByte(name, "name");
             Ensure.ArgumentDoesNotContainZeroByte(email, "email");
 

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,7 @@ public void CreatingASignatureWithBadParamsThrows()`
`35`	`35`	`Assert.Throws<ArgumentNullException>(() => new Signature(null, "me@there.com", DateTimeOffset.Now));`
`36`	`36`	`Assert.Throws<ArgumentException>(() => new Signature(string.Empty, "me@there.com", DateTimeOffset.Now));`
`37`	`37`	`Assert.Throws<ArgumentNullException>(() => new Signature("Me", null, DateTimeOffset.Now));`
`38`		`- }`
`39`		`-`
`40`		`- [Fact]`
`41`		`- public void CanCreateASignatureWithAnEmptyEmail()`
`42`		`- {`
`43`		`- var sig = new Signature("Me", string.Empty, DateTimeOffset.Now);`
`44`		`- Assert.Equal(string.Empty, sig.Email);`
	`38`	`+ Assert.Throws<ArgumentException>(() => new Signature("Me", string.Empty, DateTimeOffset.Now));`
`45`	`39`	`}`
`46`	`40`	`}`
`47`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ internal Signature(IntPtr signaturePtr)`
`36`	`36`	`public Signature(string name, string email, DateTimeOffset when)`
`37`	`37`	`{`
`38`	`38`	`Ensure.ArgumentNotNullOrEmptyString(name, "name");`
`39`		`- Ensure.ArgumentNotNull(email, "email");`
	`39`	`+ Ensure.ArgumentNotNullOrEmptyString(email, "email");`
`40`	`40`	`Ensure.ArgumentDoesNotContainZeroByte(name, "name");`
`41`	`41`	`Ensure.ArgumentDoesNotContainZeroByte(email, "email");`
`42`	`42`