8000 basicCancel of invalid cTag on AutorecoveringChannel throws NullPointerException · Issue #105 · rabbitmq/rabbitmq-java-client · GitHub
[go: up one dir, main page]
Skip to content

basicCancel of invalid cTag on AutorecoveringChannel throws NullPointerException #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spatula75 opened this issue Nov 19, 2015 · 1 comment
Closed

basicCancel of invalid cTag on AutorecoveringChannel throws NullPointerException #105

spatula75 opened this issue Nov 19, 2015 · 1 comment
Assignees
@michaelklishin
Labels
effort-tiny
Milestone
3.5.7

Comments

@spatula75
Copy link

In basicCancel:

    public void basicCancel(String consumerTag) throws IOException {
        RecordedConsumer c = this.deleteRecordedConsumer(consumerTag);
        this.maybeDeleteRecordedAutoDeleteQueue(c.getQueue());
        delegate.basicCancel(consumerTag);
    }

For a consumerTag that isn't actually known for any reason, this.deleteRecordedConsumer will return null. When c.getQueue() is called in the following line, a NullPointerException is thrown.

It would be more desirable to null-check 'c' and throw an appropriate subclass of IOException indicating that the Consumer does not exist / is not known, or do nothing, whichever makes more sense to be orthogonal with the non-recovering version of Channel.

See also https://groups.google.com/forum/#!topic/rabbitmq-users/nIpvcQh4M1M
@michaelklishin michaelklishin self-assigned this Nov 20, 2015
@michaelklishin michaelklishin added this to the 3.5.7 milestone Nov 20, 2015
michaelklishin added a commit that referenced this issue Nov 20, 2015
@michaelklishin
Fixes #105
cec5454
michaelklishin added a commit that referenced this issue Nov 20, 2015
@michaelklishin
Merge pull request #106 from rabbitmq/rabbitmq-java-client-105
2b18b17 
Fixes #105
@michaelklishin michaelklishin mentioned this issue Nov 20, 2015
Merged
@michaelklishin
Copy link
Contributor

Fixed in #106.

stream-iori pushed a commit to stream-iori/rabbitmq-java-client that referenced this issue Mar 20, 2022
@HzjNeverStop
Use github-action instead of travis (rabbitmq#105)
19fd886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
effort-tiny
Projects
None yet
Milestone
3.5.7
Development

No branches or pull requests
2 participants
@michaelklishin @spatula75
0