Enable skipIfXpu to support class-level skipping #151420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151420
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit c5787b8 with merge base cd7bc60 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
commented
Apr 16, 2025
| ) | ||
| expected_ref = torch.xpu.is_available() | ||
| expected_res = "test_case_1" not in rc | ||
| self.assertEqual(expected_ref, expected_res) |
There was a problem hiding this comment.
Since the test class is decorated by skipIfXpu, all the test cases are skipped only for XPU.
EikanWang
commented
Apr 16, 2025
Comment on lines
+765
to
+767
| expected_ref = torch.xpu.is_available() | ||
| expected_res = "test_case_2" not in rc | ||
| self.assertEqual(expected_ref, expected_res) |
There was a problem hiding this comment.
The test_case_2 is decoreated by skipIfXpu while the other test cases are not. Therefore, the literal "test_case_2" should not appear in the output when the XPU is available.
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/14999417333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):