Raise BufferError for DLPack buffer-related errors.
#150691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150691
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c25232c with merge base 85bfaf8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 4, 2025
ysiraichi
added a commit
that referenced
this pull request
Apr 4, 2025
This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: cfaa90f Pull Request resolved: #150691
ysiraichi
added a commit
that referenced
this pull request
Apr 4, 2025
This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: fc97736 Pull Request resolved: #150691
Skylion007
approved these changes
Apr 8, 2025
ysiraichi
added a commit
that referenced
this pull request
Apr 25, 2025
This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 486a998 Pull Request resolved: #150691
ysiraichi
added a commit
that referenced
this pull request
Apr 25, 2025
This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: c3b89e9 Pull Request resolved: #150691
ysiraichi
added a commit
that referenced
this pull request
Apr 26, 2025
This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: bca99f7 Pull Request resolved: #150691
msaroufim
reviewed
May 14, 2025
| @@ -69,29 +69,29 @@ DLDataType getDLDataType(const Tensor& t) { | |||
| case ScalarType::Float8_e4m3fn: | |||
| case ScalarType::Float8_e4m3fnuz: | |||
| case ScalarType::Float8_e8m0fnu: | |||
| TORCH_CHECK(false, "float8 types are not supported by dlpack"); | |||
| TORCH_CHECK_BUFFER(false, "float8 types are not supported by dlpack"); | |||
There was a problem hiding this comment.
maybe the more specific error would be not supported by 1.0, it is supported for example by 1.1 now https://github.com/dmlc/dlpack/releases
Curious to hear your reasoning for why we shouldn't just upgrade to 1.1
albanD
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
BufferErrorfor DLPack buffer-related errors. #150691This PR addresses the Array API documentation for
__dlpack__andfrom_dlpackby making some buffer-related errorsBufferErrorinstead of
RuntimeError, e.g. incompatible dtype, strides, or device.