10BC0 Raise `BufferError` for DLPack buffer-related errors. by ysiraichi · Pull Request #150691 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Raise BufferError for DLPack buffer-related errors. #150691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Raise BufferError for DLPack buffer-related errors. #150691

wants to merge 17 commits into from

Conversation

ysiraichi
Copy link
Collaborator
@ysiraichi ysiraichi commented Apr 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR addresses the Array API documentation for __dlpack__ and
from_dlpack by making some buffer-related errors BufferError
instead of RuntimeError, e.g. incompatible dtype, strides, or device.

@ysiraichi
Update
121d64f 
[ghstack-poisoned]
This was referenced Apr 4, 2025
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150691

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 46f6ffc with merge base 7cc1a95 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Apr 4, 2025
Closed
Closed
@ysiraichi ysiraichi added module: dlpack release notes: python_frontend python frontend release notes category labels Apr 4, 2025
@ysiraichi
Update
a309dd1 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Apr 4, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
1fc3a08 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: fc97736
Pull Request resolved: #150691
@ysiraichi
Update
8e6ee74 
[ghstack-poisoned]
@ysiraichi
Update
363fa7a 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Apr 25, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
387555b 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: c3b89e9
Pull Request resolved: #150691
@ysira 10BC0 ichi ysiraichi requested review from albanD and rgommers April 25, 2025 23:34
@ysiraichi
Update
c25232c 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Apr 26, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
e2ff2ad 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: bca99f7
Pull Request resolved: #150691
msaroufim
msaroufim reviewed May 14, 2025
View reviewed changes
aten/src/ATen/DLConvertor.cpp
case ScalarType::Float8_e4m3fnuz:
case ScalarType::Float8_e8m0fnu:
TORCH_CHECK(false, "float8 types are not supported by dlpack");
TORCH_CHECK_BUFFER(false, "float8 types are not supported by dlpack");
Copy link
Member
@msaroufim msaroufim May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the more specific error would be not supported by 1.0, it is supported for example by 1.1 now https://github.com/dmlc/dlpack/releases

Curious to hear your reasoning for why we shouldn't just upgrade to 1.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we could do that. But, maybe in a later PR.

@ysiraichi
Update
fdcd11c 
[ghstack-poisoned]
@ysiraichi
Rebased.
e740e3f 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request May 24, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
441f97e 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: 6914afe
Pull Request resolved: #150691
@ysiraichi
Update
31f2b71 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request May 30, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors. E880
e6469ba 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: e424099
Pull Request resolved: #150691
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
82ade76 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 13, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
84d6d3a 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: 335dac1
Pull Request resolved: #150691
@ysiraichi
Copy link
Collaborator Author

@albanD I think I have addressed all of the reviews.
Could you take a look at this stack of PRs, again?

@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
9fca260 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
9e80607 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 20, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
c649020 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: 21bc769
Pull Request resolved: #150691
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
d87eb2d 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jun 28, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
1dca69c 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: e21030d
Pull Request resolved: #150691
@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@ysiraichi
Rebased. on "Raise BufferError for DLPack buffer-related errors."
72d8fb1 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
7021de4 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jul 12, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
20f791e 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: 31c28de
Pull Request resolved: #150691
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
f17e477 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jul 19, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
ab2a036 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-a
224F
pis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: a4b20b7
Pull Request resolved: #150691
@ysiraichi
Update on "Raise BufferError for DLPack buffer-related errors."
46f6ffc 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Jul 19, 2025
@ysiraichi
Raise BufferError for DLPack buffer-related errors.
0bc8b4c 
This PR addresses the Array API documentation for [`__dlpack__`][1] and
[`from_dlpack`][2] by making some buffer-related errors `BufferError`
instead of `RuntimeError`, e.g. incompatible dtype, strides, or device.

[1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html
[2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack

ghstack-source-id: 1ba90aa
Pull Request resolved: #150691
@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ysiraichi/87/head branch August 19, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msaroufim msaroufim msaroufim left review comments

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@rgommers rgommers Awaiting requested review from rgommers

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: dlpack open source release notes: python_frontend python frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ysiraichi @pytorchmergebot @Skylion007 @msaroufim @albanD @pytorchbot
0