WIP: Remove Conda Instructions #150646
Closed
WIP: Remove Conda Instructions #150646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150646
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New FailuresAs of commit 8b6e4c0 with merge base c59aaa0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
AlannaBurke
commented
Apr 8, 2025
| @@ -111,7 +111,9 @@ source venv/bin/activate # or `& .\venv\Scripts\Activate.ps1` on Windows | |||
| you can always `uninstall` with `timeout` or in a loop if you're feeling | |||
| lazy.) | |||
|
|
|||
| ```bash | |||
| <!--- | |||
AlannaBurke
commented
Apr 8, 2025
| @@ -665,12 +659,15 @@ tweaked to adjust the stack sampling rate, see the `py-spy` readme for more | |||
| details. | |||
|
|
|||
| ## Managing multiple build trees | |||
|
|
|||
| <!--- | |||
AlannaBurke
commented
Apr 8, 2025
| # (optional) If using torch.compile with inductor/triton, install the matching version of triton | ||
| # Run from the pytorch directory after cloning | ||
| # CUDA only: Add LAPACK support for the GPU if needed. | ||
| conda install -c pytorch magma-cuda121 # or the magma-cuda* that matches your CUDA version from https://anaconda.org/pytorch/repo |
There was a problem hiding this comment.
Does this need an update?
AlannaBurke
commented
Apr 8, 2025
| @@ -162,6 +160,9 @@ graphics cards. Please replace your GPU package with the CPU one. | |||
| ImportError: DLL load failed: The operating system cannot run %1. | |||
|
|
|||
|
|
|||
| .. | |||
AlannaBurke
commented
Apr 8, 2025
| @@ -45,7 +45,7 @@ Important if you want to run on AMD GPU: | |||
| point for HIPifying our codebase. | |||
|
|
|||
| Tools which are only situationally useful: | |||
|
|
|||
| <!-- TODO: update --> | |||
|
Would you be open to linking to a third-party Conda package? In conda-forge.org, we maintain one: https://github.com/conda-forge/pytorch-cpu-feedstock Would be happy to discuss wording 🙂 |
malfet
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Can you please break it down into:
- PR that does formatting, but no semantic changes (say s/pytorch/PyTorch/)
- PR that removes conda references where they don't need to be
- PR with questions (that needs further discussion)
It feels like first two could be landed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149551
Removing Conda installation instructions.
Anywhere there were multiple instructions, I removed the Conda ones and left the pip ones. If I wasn't sure what to replace the instructions with, I just left a comment so we'd see all the places it's mentioned when reviewing this PR. I also cleaned up a couple of files.
cc @svekars @sekyondaMeta @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ 10000 chenyang78 @kadeng @chauhang @amjames