8000 Make tlparse able to show a summary of distinct graph breaks · Issue #153669 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Make tlparse able to show a summary of distinct graph breaks #153669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
StrongerXi opened this issue 8000 May 15, 2025 · 2 comments
Open

Make tlparse able to show a summary of distinct graph breaks #153669

StrongerXi opened this issue May 15, 2025 · 2 comments
Labels
dynamo-triage-jan2025 good first issue module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@StrongerXi
Copy link
Contributor
StrongerXi commented May 15, 2025 •
edited by pytorch-bot bot
Loading

🚀 The feature, motivation and pitch

Right now we have this in tlparse:
Image

which often contains duplicated graph breaks:
Image

The goal is to have a summary of distinct graph breaks for end users who just want to fix their graph breaks.

Alternatives

No response

Additional context

No response

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
@williamwen42
Copy link
Member

Is it enough to only log a structured trace for non-deduped graph breaks? (

pytorch/torch/_dynamo/symbolic_convert.py

Line 538 in 3aa8477

torch._logging.trace_structured(
)

Or log to a different structured logging artifact?

Should also xpost to https://github.com/pytorch/tlparse/tree/main since there may need to be changes there.

@williamwen42 williamwen42 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2025
@StrongerXi
Copy link
Contributor Author

Is it enough to only log a structured trace for non-deduped graph breaks

You mean for distinct graph breaks? That should work, but it's unclear if anyone still wants to see the duplicated graph breaks in tlparse for some reason. Maybe we can have a verbosity toggle if needed.

Overall I just want there to be some simple list of action items for users to fix graph breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dynamo-triage-jan2025 good first issue module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williamwen42 @StrongerXi
0