8000 Auto format lint not making suggestions · Issue #153273 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Auto format lint not making suggestions #153273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clee2000 opened this issue May 9, 2025 · 2 comments
Open

Auto format lint not making suggestions #153273

clee2000 opened this issue May 9, 2025 · 2 comments
Labels
module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@clee2000
Copy link
Contributor
clee2000 commented May 9, 2025 •
edited by pytorch-bot bot
Loading

Failed lint run: https://github.com/pytorch/pytorch/actions/runs/14920727886/job/41915464234?pr=153226

lint format comment job: https://github.com/pytorch/pytorch/actions/runs/14933251259/job/41954580771?pr=153226

Possibly because most recent commit 8b80563 didnt change the file that failed lint and lint format comment job doesnt run on all files? I forget the defaults for lintrunner but i think it runs only on most recent commit's changed files? need to check

First commit in PR 1aab8ed

cc @ZainRizvi @huydhn
@clee2000 clee2000 added the module: devx Related to PyTorch contribution experience (HUD, pytorchbot) label May 9, 2025
@clee2000
Copy link
Contributor Author
clee2000 commented May 9, 2025

As it turns out the action/step used for making changes is incompatible with our ciflow workflows
https://github.com/pytorch/pytorch/actions/runs/14937545643/job/41968407103?pr=149003#step:6:6

This is also stated in their docs

@huydhn
Copy link
Contributor
huydhn commented May 9, 2025

Unfortunately, this only works on non-forked PRs IIRC

@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch OSS Dev Infra
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huydhn @colesbury @clee2000
0