8000 XPU skip breaks the test_decompose_mem_bound_mm.py test suite · Issue #153239 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

XPU skip breaks the test_decompose_mem_bound_mm.py test suite #153239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iupa 8000 ikov-amd opened this issue May 9, 2025 · 1 comment · May be fixed by #153245
Open

XPU skip breaks the test_decompose_mem_bound_mm.py test suite #153239

iupaikov-amd opened this issue May 9, 2025 · 1 comment · May be fixed by #153245
Assignees
Labels
module: xpu Intel XPU related issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@iupaikov-amd
Copy link
Contributor
iupaikov-amd commented May 9, 2025

🐛 Describe the bug

When running this test as python test_decompose_mem_bound_mm.py --discover-tests it returns an empty list. Running the whole test suite just runs 0 tests.

This decorator interacts with a test class in such a way that it returns a None instead of an object and thus the whole test suite is invisible for our testing environment. The decorator logic was clearly not meant to be used with the whole test suite. If they want to skip the file then it should be added in skip list in run_test.py.

It was introduced in this PR: #140517

Cost me a bit of time to debug so I would like to propose to add some form of defense against such things either through linter, CI check or something.

Here is my PR that can be used as a quick fix: #153245

Versions

PyTorch version: 2.5.1+gita92b4ad
Is debug build: False
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: 6.5.43482-6c6182cd8

OS: Ubuntu 22.04.5 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 19.0.0git (ssh://github-emu/AMD-Lightning-Internal/llvm-project 25106 c94833ba5a117103dd7fc69d903611329c5f7ff8)
CMake version: version 3.31.2
Libc version: glibc-2.35

Python version: 3.10.16 (main, Dec 11 2024, 16:24:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.19.0-42-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: AMD Radeon PRO V710 (gfx1101)
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: 6.5.43482
MIOpen runtime version: 3.4.0
Is XNNPACK available: True

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 52 bits physical, 57 bits virtual
Byte Order: Little Endian
CPU(s): 224
On-line CPU(s) list: 0-223
Vendor ID: AuthenticAMD
Model name: AMD EPYC 9654 96-Core Processor
CPU family: 25
Model: 17
Thread(s) per core: 2
Core(s) per socket: 56
Socket(s): 2
Stepping: 1
Frequency boost: enabled
CPU max MHz: 3707.8120
CPU min MHz: 1500.0000
BogoMIPS: 4800.18
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba perfmon_v2 ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local avx512_bf16 clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid overflow_recov succor smca fsrm flush_l1d
Virtualization: AMD-V
L1d cache: 3.5 MiB (112 instances)
L1i cache: 3.5 MiB (112 instances)
L2 cache: 112 MiB (112 instances)
L3 cache: 512 MiB (16 instances)
NUMA node(s): 2
NUMA node0 CPU(s): 0-55,112-167
NUMA node1 CPU(s): 56-111,168-223
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Versions of relevant libraries:
[pip3] mypy==1.10.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.21.2
[pip3] onnx==1.16.1
[pip3] onnxscript==0.1.0.dev20240817
[pip3] optree==0.12.1
[pip3] torch==2.5.1+gita92b4ad
[pip3] torchvision==0.20.1a0+04d8fc4
[pip3] triton==3.1.0
[conda] No relevant packages

cc @gujinghui @EikanWang @fengyuan14 @guangyey

@malfet malfet added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: xpu Intel XPU related issues labels May 9, 2025
@etaf
Copy link
Collaborator
etaf commented May 13, 2025

Thanks for info, the follow up fixes: #151315 and #151420 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: xpu Intel XPU related issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
4 participants
0