8000 Have cherry-pick bot always add the current release to the PR · Issue #152212 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Have cherry-pick bot always add the current release to the PR #152212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZainRizvi opened this 8000 issue Apr 25, 2025 · 3 comments
Open

Have cherry-pick bot always add the current release to the PR #152212

ZainRizvi opened this issue Apr 25, 2025 · 3 comments
Labels
module: ci Related to continuous integration oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
2.8.0

Comments

@ZainRizvi
Copy link
Contributor
ZainRizvi commented Apr 25, 2025 •
edited by pytorch-bot bot
Loading

🚀 The feature, motivation and pitch

Goal is to make sure that any PR someone attempts to cherry pick gets the release milestone added to it for tracking.

Whenever a cherry-pick is requested on a PR, we should first try to add the current release milestone before attempting the actual cherry-pick (do it in that order in case the cherry-pick fails).

One tricky part might be automatically determining the current milestone since we create those in advance. Checking the version the latest release branch could do the trick

Alternatives

No response

Additional context

No response

cc @seemethere @malfet @pytorch/pytorch-dev-infra
@ZainRizvi ZainRizvi added oncall: releng In support of CI and Release Engineering module: ci Related to continuous integration labels Apr 25, 2025
@ZainRizvi ZainRizvi added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 25, 2025
@ZainRizvi ZainRizvi added this to the 2.7.1 milestone Apr 25, 2025
@huydhn
Copy link
Contributor
huydhn commented Apr 29, 2025

This is a QoL feature to make it easier for people to do cherry pick because we only have one release at a time

@huydhn
Copy link
Contributor
huydhn commented Apr 29, 2025

Going to move this to cold storage pending the discussion on release retros

@huydhn huydhn moved this to Cold Storage in PyTorch OSS Dev Infra Apr 29, 2025
@atalman atalman modified the milestones: 2.7.1, 2.8.0 May 14, 2025
@atalman
Copy link
Contributor
atalman commented May 14, 2025

Not required for 2.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: ci Related to continuous integration oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch OSS Dev Infra
Status: Cold Storage
Milestone
2.8.0
Development

No branches or pull requests
3 participants
@huydhn @ZainRizvi @atalman
0