8000 DISABLED test_fake_registration (__main__.TestOpProfiles) · Issue #151301 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

DISABLED test_fake_registration (__main__.TestOpProfiles) #151301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pytorch-bot bot opened this issue Apr 15, 2025 · 18 comments
Open

DISABLED test_fake_registration (__main__.TestOpProfiles) #151301

pytorch-bot bot opened this issue Apr 15, 2025 · 18 comments
Labels
module: custom-operators custom operators, custom ops, custom-operators, custom-ops module: flaky-tests Problem is a flaky test in CI module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link
pytorch-bot bot commented Apr 15, 2025

Platforms: asan, linux, mac, macos, rocm, slow, win, windows

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 37 workflow(s) with 74 failures and 37 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_fake_registration
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/test_custom_ops.py", line 4500, in test_fake_registration
    torch.library.define(
  File "/opt/conda/envs/py_3.10/lib/python3.10/functools.py", line 889, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/library.py", line 555, in define
    lib.define(name + schema, alias_analysis="", tags=tags)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/library.py", line 172, in define
    result = self.m.define(schema, alias_analysis, tuple(tags))
RuntimeError: Tried to register an operator (mylib::foo(Tensor a, Tensor b) -> Tensor) with the same name and overload name multiple times. Each overload's schema should only be registered with a single call to def(). Duplicate registration: registered at /dev/null:135. Original registration: registered at /dev/null:212

To execute this test, run the following from the base repo dir:
    python test/test_custom_ops.py TestOpProfiles.test_fake_registration

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: test_custom_ops.py

cc @clee2000 @chauhang @penguinwu @zou3519 @bdhirsh

@pytorch-bot pytorch-bot bot added module: custom-operators custom operators, custom ops, custom-operators, custom-ops module: flaky-tests Problem is a flaky test in CI skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 15, 2025
Copy link
Author
pytorch-bot bot commented Apr 15, 2025
8000 Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_fake_registration (__main__.TestOpProfiles)
  • Platforms for which to skip the test: asan, linux, mac, macos, rocm, slow, win, windows
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_fake_registration (__main__.TestOpProfiles) will be disabled in PyTorch CI for these platforms: asan, linux, mac, macos, rocm, slow, win, windows. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

How to re-enable a test

To re-enable the test globally, close the issue. To re-enable a test for only a subset of platforms, remove the platforms from the list in the issue body. This may take some time to propagate. To re-enable a test only for a PR, put Fixes #151301 in the PR body and rerun the test jobs. Note that if a test is flaky, it maybe be difficult to tell if the test is still flaky on the PR.

@pytorch-bot pytorch-bot bot added module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, oncall: pt2 labels Apr 15, 2025
Copy link
Author
pytorch-bot bot commented Apr 15, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, win, windows]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented Apr 15, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [linux, mac, macos, slow]. Either the change didn't propogate fast enough or disable bot might be broken.

@zou3519
Copy link
Contributor
zou3519 commented Apr 15, 2025

cc @angelayi

Copy link
Author
pytorch-bot bot commented Apr 29, 2025

Resolving the issue because the test is not flaky anymore after 6405 reruns without any failures and the issue hasn't been updated in 14 days. Please reopen the issue to re-disable the test if you think this is a false positive

@pytorch-bot pytorch-bot bot closed this as completed Apr 29, 2025
Copy link
Author
pytorch-bot bot commented Apr 29, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, slow, win, windows].

Copy link
Author
pytorch-bot bot commented Apr 30, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, win, windows]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented Apr 30, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented Apr 30, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, win, windows].

@pytorch-bot pytorch-bot bot reopened this Apr 30, 2025
Copy link
Author
pytorch-bot bot commented May 14, 2025

Resolving the issue because the test is not flaky anymore after 6305 reruns without any failures and the issue hasn't been updated in 14 days. Please reopen the issue to re-disable the test if you think this is a false positive

@pytorch-bot pytorch-bot bot closed this as completed May 14, 2025
Copy link
Author
pytorch-bot bot commented May 14, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [asan, linux, mac, macos, ro 8000 cm, slow, win, windows] appears to contain all the recently affected platforms [rocm].

@pytorch-bot pytorch-bot bot reopened this May 14, 2025
Copy link
Author
pytorch-bot bot commented May 14, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, rocm]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented May 15, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, win, windows]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented May 28, 2025

Resolving the issue because the test is not flaky anymore after 6105 reruns without any failures and the issue hasn't been updated in 14 days. Please reopen the issue to re-disable the test if you think this is a false positive

@pytorch-bot pytorch-bot bot closed this as completed May 28, 2025
Copy link
Author
pytorch-bot bot commented May 29, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, win, windows].

@pytorch-bot pytorch-bot bot reopened this May 29, 2025
Copy link
Author
pytorch-bot bot commented May 29, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, rocm, slow, win, windows]. Either the change didn't propogate fast enough or disable bot might be broken.

Copy link
Author
pytorch-bot bot commented May 29, 2025

Another case of trunk flakiness has been found here. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, mac, macos, win, windows]. Either the change didn't propogate fast enough or disable bot might be broken.

nWEIdia pushed a commit to nWEIdia/pytorch that referenced this issue Jun 2, 2025
Hopefully fixes pytorch#151301, pytorch#151281 by making the ops have different names
Pull Request resolved: pytorch#152484
Approved by: https://github.com/zou3519
Copy link
Author
pytorch-bot bot commented Jun 2, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [asan, linux, mac, macos, rocm, slow, win, windows] appears to contain all the recently affected platforms [asan, linux, rocm, win, windows].

@pytorch-bot pytorch-bot bot reopened this Jun 2, 2025
qingyi-yan pushed a commit to qingyi-yan/pytorch that referenced this issue Jun 3, 2025
Hopefully fixes pytorch#151301, pytorch#151281 by making the ops have different names
Pull Request resolved: pytorch#152484
Approved by: https://github.com/zou3519
iupaikov-amd pushed a commit to ROCm/pytorch that referenced this issue Jun 4, 2025
Hopefully fixes pytorch#151301, pytorch#151281 by making the ops have different names
Pull Request resolved: pytorch#152484
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: custom-operators custom operators, custom ops, custom-operators, custom-ops module: flaky-tests Problem is a flaky test in CI module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant
0