8000 DISABLED test_partitioning_unremat_bw (__main__.MinCutPartitioningTests) · Issue #145343 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

DISABLED test_partitioning_unremat_bw (__main__.MinCutPartitioningTests) #145343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pytorch-bot bot opened this issue Jan 22, 2025 · 8 comments
Closed

DISABLED test_partitioning_unremat_bw (__main__.MinCutPartitioningTests) #145343

pytorch-bot bot opened this issue Jan 22, 2025 · 8 comments
Labels
module: flaky-tests Problem is a flaky test in CI module: inductor module: rocm AMD GPU support for Pytorch oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link
pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

Platforms: rocm

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 4 workflow(s) with 5 failures and 4 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_partitioning_unremat_bw
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message 
Traceback (most recent call last):
  File "/var/lib/jenkins/pytorch/test/inductor/test_perf.py", line 718, in test_partitioning_unremat_bw
    self.assertExpectedInline(count_numel_train(f, *inp), """1300""")
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3066, in assertExpectedInline
    return super().assertExpectedInline(actual if isinstance(actual, str) else str(actual), expect, skip + 1)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 413, in assertExpectedInline
    assert_expected_inline(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 378, in assert_expected_inline
    assert_eq(expect, actual, msg=help_text)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 450, in assertMultiLineEqualMaybeCppStack
    self.assertMultiLineEqual(expect, actual, *args, **kwargs)
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 1226, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 675, in fail
    raise self.failureException(msg)
AssertionError: '1300' != '1720'
- 1300
+ 1720
 : To accept the new output, re-run test with envvar EXPECTTEST_ACCEPT=1 (we recommend staging/committing your changes before doing this)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_ROCM=1 python test/inductor/test_perf.py MinCutPartitioningTests.test_partitioning_unremat_bw

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: inductor/test_perf.py

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @clee2000 @wdvr @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: inductor module: rocm AMD GPU support for Pytorch skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 22, 2025
@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Jan 22, 2025
Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_partitioning_unremat_bw (__main__.MinCutPartitioningTests)
  • Platforms for which to skip the test: rocm
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_partitioning_unremat_bw (__main__.MinCutPartitioningTests) will be disabled in PyTorch CI for these platforms: rocm. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

How to re-enable a test

To re-enable the test globally, close the issue. To re-enable a test for only a subset of platforms, remove the platforms from the list in the issue body. This may take some time to propagate. To re-enable a test only for a PR, put Fixes #145343 in the PR body and rerun the test jobs. Note that if a test is flaky, it maybe be difficult to tell if the test is still flaky on the PR.

@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Jan 22, 2025

Another case of trunk flakiness has been found here. The list of platforms [rocm] appears to contain all the recently affected platforms [rocm]. Either the change didn't propogate fast enough or disable bot might be broken.

@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Jan 22, 2025

Another case of trunk flakiness has been found here. The list of platforms [rocm] appears to contain all the recently affected platforms [rocm]. Either the change didn't propogate fast enough or disable bot might be broken.

@jataylo
Copy link
Collaborator
jataylo commented Jan 29, 2025

Expecting #145829 to resolve this flaky issue, closing manually for faster feedback signal.

@jataylo jataylo closed this as completed Jan 29, 2025
@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Jan 30, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [rocm] appears to contain all the recently affected platforms [rocm].

@pytorch-bot pytorch-bot bot reopened this Jan 30, 2025
@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Feb 24, 2025

Resolving the issue because the test is not flaky anymore after 350 reruns without any failures and the issue hasn't been updated in 14 days. Please reopen the issue to re-disable the test if you think this is a false positive

@pytorch-bot pytorch-bot bot closed this as completed Feb 24, 2025
@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Feb 28, 2025

Another case of trunk flakiness has been found here. Reopening issue. The list of platforms [rocm] appears to contain all the recently affected platforms [rocm].

@pytorch-bot pytorch-bot bot reopened this Feb 28, 2025
@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented May 16, 2025

Resolving the issue because the test is not flaky anymore after 550 reruns without any failures and the issue hasn't been updated in 14 days. Please reopen the issue to re-disable the test if you think this is a false positive

@pytorch-bot pytorch-bot bot closed this as completed May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: flaky-tests Problem is a flaky test in CI module: inductor module: rocm AMD GPU support for Pytorch oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jataylo
0