8000 StrideAPI caused regression in channels-last logic · Issue #141836 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

StrideAPI caused regression in channels-last logic #141836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
malfet opened this issue Dec 1, 2024 · 3 comments
Open

StrideAPI caused regression in channels-last logic #141836

malfet opened this issue Dec 1, 2024 · 3 comments
Assignees
@DenisVieriu97
Labels
high priority module: mps Related to Apple Metal Performance Shaders framework module: regression It used to work, and now it doesn't triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@malfet
Copy link
Contributor
malfet commented Dec 1, 2024 •
edited
Loading

🐛 Describe the bug

#128393 caused numerous performance/correctness regressions for the ops that had a special codepath for channels last, see

Versions

2.5.0, 2.5.1, nightly

cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @kulinseth @albanD @DenisVieriu97 @jhavukainen
@malfet malfet added high priority module: regression It used to work, and now it doesn't module: mps Related to Apple Metal Performance Shaders framework labels Dec 1, 2024
@malfet malfet assigned DenisVieriu97 Dec 1, 2024
@mikaylagawarecki mikaylagawarecki added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed triage review labels Dec 2, 2024
@skotapati
Copy link
Collaborator

Some fixes may be required for the handling of channels last, Denis is investigating

@malfet
Copy link
Contributor Author
malfet commented Dec 3, 2024

It would be nice to enable non-contiguous OpInfo tests to have a coverage

@Karliz24 Karliz24 mentioned this issue Dec 11, 2024
Open
@skotapati skotapati mentioned this issue Jan 10, 2025
Closed
@kulinseth
Copy link
Collaborator

@malfet are there any remaining regressions on the strided API or can we close this ?
For non-config testing, we need reviews here #142202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisVieriu97 DenisVieriu97

Labels
high priority module: mps Related to Apple Metal Performance Shaders framework module: regression It used to work, and now it doesn't triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kulinseth @malfet @skotapati @mikaylagawarecki @DenisVieriu97
0