-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
dynamo-triage-june2024module: dynamic shapesmodule: dynamooncall: pt2smallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
Recent bug #120482 was due to someone directly accessing TensorVariable.size; fixed in #120567. But this field is None when the tensor has dynamic shapes. This is a dynamic shapes footgun. Either ban this, or change this to query size off of the fake tensor (and be willing to return SymInts).
Versions
main
cc @msaroufim @bdhirsh @anijain2305 @zou3519 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @aakhundov
Metadata
Metadata
Assignees
Labels
dynamo-triage-june2024module: dynamic shapesmodule: dynamooncall: pt2smallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module