8000 module:distributed is being misused · Issue #115168 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content
module:distributed is being misused #115168
@wconstab

Description

@wconstab

@albanD pointed out that the labels beginning with module: have a particular semantic defined in the oss triage runbook (https://docs.google.com/document/d/1XX8mhX7EsKSqBj0tNRLUffkO0jlwiLDvO_KWwdOElww/edit)

We're currently using module: distributed as a way to get cc'd but it is not a valid subcomponent for the oss triage process. So to avoid confusion we have a couple of options.

  1. just switch the labeler bot to apply oncall: distributed to PRs that used to get tagged with module: distributed and have the same set of users cc'd. Note that this is not a conflict with oncall triaging since that focuses on issues rather than PRs and auto-labeling/cc-bot only happens for PRs. Edit: actually auto-labelign also happens for issues. So for option 1 we'll all start getting CC'd on issues. (Which is probably not a bad thing, unless its just too coarse grained, which suggests (2) is better.

  2. drop the overall 'distributed' labeler entirely, and just use autolabelers for subcomponents. we could reuse our module: fsdp type labels and specify more fine grained sets of users that we want cc'd on different subcomponents.

I think i'll just default to (1) as it seems like a drop-in replacement, but if folks prefer (2) give the issue a thumbs up in the comment below. Or feel free to suggest another plan.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @kiukchung @d4l3k @LucasLLC @tianyu-l

Metadata

Metadata

Assignees

No one assigned

    Labels

    oncall: distributedAdd this issue/PR to distributed oncall triage queue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0