Makefile: refactor build, setup and lint rules

ariel-anieli · ariel-anieli · commit c48ea9abba3e · 2025-05-01T18:00:30.000+02:00
build rules, `setup_env_*` and `setup-env-*` differ by one flag; `quicklint` and `lint` call the same command. Refactor by using pattern rules. Link: https://www.gnu.org/software/make/manual/html_node/Pattern-Examples.html Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
diff --git a/Makefile b/Makefile
@@ -2,18 +2,16 @@
 PYTHON = python3
 PIP = $(PYTHON) -m pip
 NIGHTLY_TOOL_OPTS := pull
+BUILD_TARGETS := android ios local
+PLATFORMS := cuda rocm
+SETUP_ENVS := $(PLATFORMS:%=setup-env-%)
+SETUP_ENV_PLATFORMS := $(PLATFORMS:%=setup_env_%)
 
 all:
 	@mkdir -p build && cd build && cmake .. $(shell $(PYTHON) ./scripts/get_python_cmake_flags.py) && $(MAKE)
 
-local:
-	@./scripts/build_local.sh
-
-android:
-	@./scripts/build_android.sh
-
-ios:
-	@./scripts/build_ios.sh
+$(BUILD_TARGETS): %:
+	@./scripts/build_$*.sh
 
 clean: # This will remove ALL build folders.
 	@rm -r build*/
@@ -32,26 +30,19 @@ ensure-branch-clean:
 setup-env: ensure-branch-clean
 	$(PYTHON) tools/nightly.py $(NIGHTLY_TOOL_OPTS)
 
-setup-env-cuda:
-	$(MAKE) setup-env PYTHON="$(PYTHON)" NIGHTLY_TOOL_OPTS="$(NIGHTLY_TOOL_OPTS) --cuda"
-
-setup-env-rocm:
-	$(MAKE) setup-env PYTHON="$(PYTHON)" NIGHTLY_TOOL_OPTS="$(NIGHTLY_TOOL_OPTS) --rocm"
+$(SETUP_ENVS): setup-env-%:
+	$(MAKE) setup-env PYTHON="$(PYTHON)" NIGHTLY_TOOL_OPTS="$(NIGHTLY_TOOL_OPTS) --$*"
 
 setup_env: setup-env
-setup_env_cuda: setup-env-cuda
-setup_env_rocm: setup-env-rocm
+$(SETUP_ENV_PLATFORMS): setup_env_%: setup-env-%
 
 setup-lint:
 	$(PIP) install lintrunner
 	lintrunner init
 
 setup_lint: setup-lint
 
-lint:
-	lintrunner
-
-quicklint:
+lint quicklint:
 	lintrunner
 
 triton:
