Update on "[aoti] fix corner case in unbacked replacements for atomically_apply_size_hint"

ColinPeppler · ColinPeppler · commit c2285100d8b3 · 2025-05-16T16:22:03.000-07:00
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
diff --git a/test/inductor/test_aot_inductor.py b/test/inductor/test_aot_inductor.py
@@ -1322,7 +1322,9 @@ def forward(self, values, repeats, mask, embeddings, x, z, scalar):
         self.check_model(Repro(), example_inputs, dynamic_shapes=spec)
 
     def test_size_with_unbacked_add_expr_transitive(self):
-        # We'll have torch._check(expr1, expr2) + torch._check(expr2, unbacked)
+        # Edge case with torch._check(expr1, expr2) + torch._check(expr2, unbacked).
+        # When generating example input sizes for autotuning, it should coalesce
+        # expr1, expr2, unbacked into a single size.
         if self.device != GPU_TYPE:
             raise unittest.SkipTest("requires GPU")
 
@@ -1377,6 +1379,8 @@ def forward(self, values, repeats, mask, embeddings, x, y, z, lst):
 
     @config.patch({"unbacked_symint_fallback": 1024})
     def test_size_with_unbacked_add_and_mul_expr(self):
+        # Edge case with torch._check(add_expr, mul_expr). When generating example
+        # input sizes for autotuning, make sure they coalesce into a single size.
         if self.device != GPU_TYPE:
             raise unittest.SkipTest("requires GPU")
 
