[C10] Add Scalar::isUnsigned() method

malfet · malfet · commit b5248dc2975f · 2025-08-05T10:03:48.000-07:00
That returns true if Scalar hold unsigned integral value With the implications of `Tag::HAS_u` semantic. ghstack-source-id: 4b6248f Pull Request resolved: #159877
diff --git a/c10/core/Scalar.h b/c10/core/Scalar.h
@@ -191,11 +191,17 @@ class C10_API Scalar {
   isIntegral() const {
     return Tag::HAS_i == tag || Tag::HAS_si == tag || Tag::HAS_u == tag;
   }
+
   bool isIntegral(bool includeBool) const {
     return Tag::HAS_i == tag || Tag::HAS_si == tag || Tag::HAS_u == tag ||
         (includeBool && isBoolean());
   }
 
+  // See Note [Meaning of HAS_u]
+  bool isUnsigned() const {
+    return Tag::HAS_u == tag || (Tag::HAS_i == tag && v.i >= 0);
+  }
+
   bool isComplex() const {
     return Tag::HAS_z == tag;
   }

Original file line number	Diff line number	Diff line change
`@@ -191,11 +191,17 @@ class C10_API Scalar {`
`191`	`191`	`isIntegral() const {`
`192`	`192`	`return Tag::HAS_i == tag \|\| Tag::HAS_si == tag \|\| Tag::HAS_u == tag;`
`193`	`193`	`}`
	`194`	`+`
`194`	`195`	`bool isIntegral(bool includeBool) const {`
`195`	`196`	`return Tag::HAS_i == tag \|\| Tag::HAS_si == tag \|\| Tag::HAS_u == tag \|\|`
`196`	`197`	`(includeBool && isBoolean());`
`197`	`198`	`}`
`198`	`199`
	`200`	`+ // See Note [Meaning of HAS_u]`
	`201`	`+ bool isUnsigned() const {`
	`202`	`+ return Tag::HAS_u == tag \|\| (Tag::HAS_i == tag && v.i >= 0);`
	`203`	`+ }`
	`204`	`+`
`199`	`205`	`bool isComplex() const {`
`200`	`206`	`return Tag::HAS_z == tag;`
`201`	`207`	`}`