Update base for Update on "Remove det_singular OpInfo"

soulitzer · soulitzer · commit 8dbd7b28545b · 2025-01-23T17:56:19.000-05:00
Fixes #93045 #93044 From previous discussion #93045 (comment) the resolution is that we're okay with removing this. Some older attempts: - #102581 - #109249 cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
diff --git a/test/test_autograd.py b/test/test_autograd.py
@@ -12466,7 +12466,10 @@ def test_disallow_nesting(self):
 
     def test_inplace_foreach(self):
         with torch.autograd.graph.allow_mutation_on_saved_tensors():
-            a = [torch.tensor(1., requires_grad=True), torch.tensor(1., requires_grad=True)]
+            a = [
+                torch.tensor(1., requires_grad=True),
+                torch.tensor(1., requires_grad=True)
+            ]
             b = torch._foreach_exp(a)
             torch._foreach_add_(b, 1)
             (b[0] + b[1]).backward()
diff --git a/torch/nested/_internal/ops.py b/torch/nested/_internal/ops.py
@@ -585,14 +585,8 @@ def linear_backward_default(func, *args, **kwargs):
         input_2d = inp._values.reshape(-1, weight.size(1))
         dw = torch.matmul(grad_2d.t(), input_2d)
     if output_mask[2]:
-        # Sum over all but the last dim to get a 1D bias grad. We cannot
-        # rely on the autograd engine to reduce for us, because returning a
-        # tensor aliasing the input would violate the aten signature annotation
-        reduce_dims = tuple(range(grad_output._values.ndim - 1))
-        if reduce_dims == ():
-            db = grad_output._values.clone()
-        else:
-            db = torch.sum(grad_output._values, reduce_dims, keepdim=False)
+        # NB: autograd engine will sum over all but the last dim to get a 1D bias grad.
+        db = grad_output._values.detach()
     return (ds, dw, db)
 
 
