8000 Update on "Remove det_singular OpInfo" · pytorch/pytorch@4620dec · GitHub
[go: up one dir, main page]

Skip to content

Commit 4620dec

Browse files
committed
Update on "Remove det_singular OpInfo"
Fixes #93045 #93044 Based on some previous attempts: - #102581 - #109249 [ghstack-poisoned]
1 parent 2f93768 commit 4620dec

File tree

5 files changed

+0
-20
lines changed

5 files changed

+0
-20
lines changed

test/distributed/tensor/test_dtensor_ops.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ def wrapped(fn):
190190
xfail("linalg.cholesky_ex"),
191191
xfail("linalg.cross"),
192192
xfail("linalg.det"),
193-
xfail("linalg.det", "singular"),
194193
xfail("linalg.eig"),
195194
xfail("linalg.eigvals"),
196195
xfail("linalg.householder_product"),

test/functorch/test_ops.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@
4646
from torch.testing._internal.common_methods_invocations import op_db
4747
from torch.testing._internal.common_utils import (
4848
is_iterable_of_tensors,
49-
IS_MACOS,
50-
IS_X86,
5149
noncontiguous_like,
5250
parametrize,
5351
run_tests,
@@ -587,11 +585,6 @@ def abs_if_complex(t):
587585
xfail("as_strided"),
588586
xfail("as_strided", "partial_views"),
589587
xfail("as_strided_scatter"),
590-
decorate(
591-
"linalg.det",
592-
"singular",
593-
decorator=expectedFailureIf(IS_MACOS and IS_X86),
594-
),
595588
}
596589
),
597590
)
@@ -877,9 +870,6 @@ def f(inp, *args, **kwargs):
877870
tol1("masked.cumprod", {torch.float32: tol(atol=5e-04, rtol=5e-04)}),
878871
tol1("cumprod", {torch.float32: tol(atol=5e-04, rtol=5e-04)}),
879872
tol1("linalg.vander", {torch.float32: tol(atol=5e-04, rtol=5e-04)}),
880-
tol2(
881-
"linalg.det", "singular", {torch.float32: tol(atol=2e-05, rtol=2e-05)}
882-
),
883873
),
884874
)
885875
def test_vjpvjp(self, device, dtype, op):
@@ -1348,11 +1338,6 @@ def test_vmapvjp(self, device, dtype, op):
13481338
vmapjvpall_fail.union(
13491339
{
13501340
xfail("as_strided_copy"),
1351-
decorate(
1352-
"linalg.det",
1353-
"singular",
1354-
decorator=expectedFailureIf(IS_MACOS and IS_X86),
1355-
),
13561341
}
13571342
),
13581343
)

test/inductor/test_torchinductor_opinfo.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,6 @@ def format_op(op):
282282
"inner": {f64},
283283
"linalg.cholesky_ex": {f64},
284284
"linalg.cholesky": {f64},
285-
("linalg.det", "singular"): {f64},
286285
"linalg.ldl_factor_ex": {f64},
287286
"linalg.ldl_factor": {f64},
288287
"linalg.ldl_solve": {f64},

test/test_mps.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,6 @@ def mps_ops_modifier(ops):
700700
'linalg.cholesky': None,
701701
'linalg.cholesky_ex': None,
702702
'linalg.cond': None,
703-
'linalg.detsingular': None,
704703
'linalg.det': None,
705704
'linalg.eigh': None,
706705
'linalg.eigvalsh': None,

torch/testing/_internal/opinfo/definitions/linalg.py

Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@
3434
all_types_and_complex_and,
3535
floating_and_complex_types,
3636
floating_and_complex_types_and,
37-
get_all_complex_dtypes,
3837
)
3938
from torch.testing._internal.common_utils import (
4039
GRADCHECK_NONDET_TOL,
41-
IS_MACOS,
4240
make_fullrank_matrices_with_distinct_singular_values,
4341
skipIfSlowGradcheckEnv,
4442
slowTest,

0 commit comments

Comments
 (0)
0